Repository: ambari Updated Branches: refs/heads/trunk 4c56e4e66 -> 897b67a55
AMBARI-7870. Change ShellCommandUtil.Results class from package private to public Project: http://git-wip-us.apache.org/repos/asf/ambari/repo Commit: http://git-wip-us.apache.org/repos/asf/ambari/commit/897b67a5 Tree: http://git-wip-us.apache.org/repos/asf/ambari/tree/897b67a5 Diff: http://git-wip-us.apache.org/repos/asf/ambari/diff/897b67a5 Branch: refs/heads/trunk Commit: 897b67a5549b1fa93b339370c789764c489ed471 Parents: 4c56e4e Author: Robert Levas <[email protected]> Authored: Thu Oct 23 16:21:03 2014 -0400 Committer: John Speidel <[email protected]> Committed: Thu Oct 23 17:22:57 2014 -0400 ---------------------------------------------------------------------- .../apache/ambari/server/utils/ShellCommandUtil.java | 8 ++++---- .../ambari/server/utils/TestShellCommandUtil.java | 15 ++++++++++++++- 2 files changed, 18 insertions(+), 5 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/ambari/blob/897b67a5/ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java ---------------------------------------------------------------------- diff --git a/ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java b/ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java index ee83aa0..947b336 100644 --- a/ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java +++ b/ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java @@ -200,7 +200,7 @@ public class ShellCommandUtil { return sb.toString(); } - static class Result { + public static class Result { Result(int exitCode, String stdout, String stderr) { this.exitCode = exitCode; @@ -212,15 +212,15 @@ public class ShellCommandUtil { private final String stdout; private final String stderr; - int getExitCode() { + public int getExitCode() { return exitCode; } - String getStdout() { + public String getStdout() { return stdout; } - String getStderr() { + public String getStderr() { return stderr; } http://git-wip-us.apache.org/repos/asf/ambari/blob/897b67a5/ambari-server/src/test/java/org/apache/ambari/server/utils/TestShellCommandUtil.java ---------------------------------------------------------------------- diff --git a/ambari-server/src/test/java/org/apache/ambari/server/utils/TestShellCommandUtil.java b/ambari-server/src/test/java/org/apache/ambari/server/utils/TestShellCommandUtil.java index 27a033c..fc27eda 100644 --- a/ambari-server/src/test/java/org/apache/ambari/server/utils/TestShellCommandUtil.java +++ b/ambari-server/src/test/java/org/apache/ambari/server/utils/TestShellCommandUtil.java @@ -37,6 +37,10 @@ import java.io.File; import java.io.FileOutputStream; import java.io.IOException; import java.lang.reflect.Constructor; +import java.lang.reflect.Method; +import java.lang.reflect.Modifier; +import java.security.ProtectionDomain; +import java.util.Arrays; import java.util.Properties; import java.util.Random; @@ -142,5 +146,14 @@ public class TestShellCommandUtil extends TestCase { assertFalse(ShellCommandUtil.hideOpenSslPassword(command_pass).contains("1234")); assertFalse(ShellCommandUtil.hideOpenSslPassword(command_key).contains("1234")); } - + + public void testResultsClassIsPublic() throws Exception { + Class resultClass = ShellCommandUtil.Result.class; + + assertEquals(Modifier.PUBLIC, resultClass.getModifiers() & Modifier.PUBLIC); + + for(Method method : resultClass.getMethods()) { + assertEquals(method.getName(), Modifier.PUBLIC, (method.getModifiers() & Modifier.PUBLIC)); + } + } }
