Repository: ambari Updated Branches: refs/heads/trunk f2c892ad9 -> f25834109
AMBARI-11774 - Views : NPE accessing view that includes velocity. (tbeerbower) Project: http://git-wip-us.apache.org/repos/asf/ambari/repo Commit: http://git-wip-us.apache.org/repos/asf/ambari/commit/f2583410 Tree: http://git-wip-us.apache.org/repos/asf/ambari/tree/f2583410 Diff: http://git-wip-us.apache.org/repos/asf/ambari/diff/f2583410 Branch: refs/heads/trunk Commit: f25834109c3096985631db8490c90a33656ecee9 Parents: f2c892a Author: tbeerbower <[email protected]> Authored: Mon Jun 8 06:00:55 2015 -0400 Committer: tbeerbower <[email protected]> Committed: Mon Jun 8 06:01:06 2015 -0400 ---------------------------------------------------------------------- .../java/org/apache/ambari/server/view/ViewClassLoader.java | 1 + .../org/apache/ambari/server/view/ViewClassLoaderTest.java | 6 ++++++ 2 files changed, 7 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/ambari/blob/f2583410/ambari-server/src/main/java/org/apache/ambari/server/view/ViewClassLoader.java ---------------------------------------------------------------------- diff --git a/ambari-server/src/main/java/org/apache/ambari/server/view/ViewClassLoader.java b/ambari-server/src/main/java/org/apache/ambari/server/view/ViewClassLoader.java index c90bcaa..692f728 100644 --- a/ambari-server/src/main/java/org/apache/ambari/server/view/ViewClassLoader.java +++ b/ambari-server/src/main/java/org/apache/ambari/server/view/ViewClassLoader.java @@ -81,6 +81,7 @@ public class ViewClassLoader extends WebAppClassLoader { // add as system classes to avoid conflicts and linkage errors webAppContext.addSystemClass("org.slf4j."); webAppContext.addSystemClass("com.sun.jersey."); + webAppContext.addSystemClass("org.apache.velocity."); // set the class loader settings from the configuration if (viewConfig != null) { http://git-wip-us.apache.org/repos/asf/ambari/blob/f2583410/ambari-server/src/test/java/org/apache/ambari/server/view/ViewClassLoaderTest.java ---------------------------------------------------------------------- diff --git a/ambari-server/src/test/java/org/apache/ambari/server/view/ViewClassLoaderTest.java b/ambari-server/src/test/java/org/apache/ambari/server/view/ViewClassLoaderTest.java index f831989..d2f0c8f 100644 --- a/ambari-server/src/test/java/org/apache/ambari/server/view/ViewClassLoaderTest.java +++ b/ambari-server/src/test/java/org/apache/ambari/server/view/ViewClassLoaderTest.java @@ -80,6 +80,7 @@ public class ViewClassLoaderTest { expect(parentClassLoader.loadClass("com.google.inject.AbstractModule")).andReturn(parentClass).once(); expect(parentClassLoader.loadClass("org.slf4j.LoggerFactory")).andReturn(parentClass).once(); expect(parentClassLoader.loadClass("com.sun.jersey.api.ConflictException")).andReturn(parentClass).once(); + expect(parentClassLoader.loadClass("org.apache.velocity.VelocityContext")).andReturn(parentClass).once(); replay(parentClassLoader, viewConfig); @@ -126,6 +127,11 @@ public class ViewClassLoaderTest { Assert.assertNotNull(clazz); Assert.assertSame(parentClass, clazz); + clazz = classLoader.loadClass("org.apache.velocity.VelocityContext"); + + Assert.assertNotNull(clazz); + Assert.assertSame(parentClass, clazz); + verify(parentClassLoader, viewConfig); }
