Repository: ambari Updated Branches: refs/heads/trunk 1b06cd40c -> fce74508c
AMBARI-15684. Provide more intuitive error message when unable to change Ambari server pid or log dirs (aonishuk) Project: http://git-wip-us.apache.org/repos/asf/ambari/repo Commit: http://git-wip-us.apache.org/repos/asf/ambari/commit/fce74508 Tree: http://git-wip-us.apache.org/repos/asf/ambari/tree/fce74508 Diff: http://git-wip-us.apache.org/repos/asf/ambari/diff/fce74508 Branch: refs/heads/trunk Commit: fce74508c7e235314f723fe98e3ebbb67458794a Parents: 1b06cd4 Author: Andrew Onishuk <[email protected]> Authored: Mon Apr 4 16:10:16 2016 +0300 Committer: Andrew Onishuk <[email protected]> Committed: Mon Apr 4 16:10:40 2016 +0300 ---------------------------------------------------------------------- .../src/main/python/ambari_server/serverConfiguration.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/ambari/blob/fce74508/ambari-server/src/main/python/ambari_server/serverConfiguration.py ---------------------------------------------------------------------- diff --git a/ambari-server/src/main/python/ambari_server/serverConfiguration.py b/ambari-server/src/main/python/ambari_server/serverConfiguration.py index 001afd1..5a0c8e8 100644 --- a/ambari-server/src/main/python/ambari_server/serverConfiguration.py +++ b/ambari-server/src/main/python/ambari_server/serverConfiguration.py @@ -27,6 +27,7 @@ import stat import string import sys import tempfile +import getpass import ambari_server.serverClassPath from ambari_commons.exceptions import FatalException @@ -387,9 +388,9 @@ class ServerConfigDefaults(object): self.MESSAGE_CHECK_FIREWALL = "" def check_if_directories_writable(self, directories): - for dir in directories: - if not os.path.isdir(dir) or not os.access(dir, os.W_OK): - raise FatalException(-1, "Please make sure {0} directory is created, and is writable by ambari-server user".format(dir)) + for directory in directories: + if not os.path.isdir(directory) or not os.access(directory, os.W_OK): + raise FatalException(-1, "Unable to access {0} directory. Confirm the directory is created and is writable by the Ambari Server user account '{1}'".format(directory, getpass.getuser())) @OsFamilyImpl(os_family=OSConst.WINSRV_FAMILY) class ServerConfigDefaultsWindows(ServerConfigDefaults):
