Repository: ambari Updated Branches: refs/heads/trunk 32ab17b33 -> 120505f9a
AMBARI-18494 Js error when changing config group via dropdown. (ababiichuk) Project: http://git-wip-us.apache.org/repos/asf/ambari/repo Commit: http://git-wip-us.apache.org/repos/asf/ambari/commit/120505f9 Tree: http://git-wip-us.apache.org/repos/asf/ambari/tree/120505f9 Diff: http://git-wip-us.apache.org/repos/asf/ambari/diff/120505f9 Branch: refs/heads/trunk Commit: 120505f9a2b4da35604564f0ab066ad67fecd86a Parents: 013b7bd Author: ababiichuk <[email protected]> Authored: Thu Sep 29 17:09:42 2016 +0300 Committer: ababiichuk <[email protected]> Committed: Fri Sep 30 10:33:49 2016 +0300 ---------------------------------------------------------------------- .../app/mixins/common/configs/config_recommendation_parser.js | 2 +- .../mixins/common/configs/config_recommendation_parser_test.js | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/ambari/blob/120505f9/ambari-web/app/mixins/common/configs/config_recommendation_parser.js ---------------------------------------------------------------------- diff --git a/ambari-web/app/mixins/common/configs/config_recommendation_parser.js b/ambari-web/app/mixins/common/configs/config_recommendation_parser.js index b88cf62..d07d108 100644 --- a/ambari-web/app/mixins/common/configs/config_recommendation_parser.js +++ b/ambari-web/app/mixins/common/configs/config_recommendation_parser.js @@ -82,7 +82,7 @@ App.ConfigRecommendationParser = Em.Mixin.create(App.ConfigRecommendations, { propertiesToDelete.push(config); } else if (attr === 'visible' || stackProperty) { /** update config boundaries **/ - updateBoundariesCallback(stackProperty, attr, propertyAttributes[attr], name, fileName, configGroup); + updateBoundariesCallback(stackProperty, attr, propertyAttributes[attr], configGroup); } } } http://git-wip-us.apache.org/repos/asf/ambari/blob/120505f9/ambari-web/test/mixins/common/configs/config_recommendation_parser_test.js ---------------------------------------------------------------------- diff --git a/ambari-web/test/mixins/common/configs/config_recommendation_parser_test.js b/ambari-web/test/mixins/common/configs/config_recommendation_parser_test.js index f08bbad..c7c24d4 100644 --- a/ambari-web/test/mixins/common/configs/config_recommendation_parser_test.js +++ b/ambari-web/test/mixins/common/configs/config_recommendation_parser_test.js @@ -102,12 +102,12 @@ describe('App.ConfigRecommendationParser', function() { it('updateBoundariesCallback maximum', function() { expect(instanceObject.updateBoundariesCallback.calledWith({ name: 'p3', filename: 'fileName1' }, - 'maximum', 100, 'p3', 'fileName1', null)).to.be.true; + 'maximum', 100, null)).to.be.true; }); it('updateBoundariesCallback minimum', function() { expect(instanceObject.updateBoundariesCallback.calledWith({ name: 'p3', filename: 'fileName1' }, - 'minimum', 1, 'p3', 'fileName1', null)).to.be.true; + 'minimum', 1, null)).to.be.true; }); });
