Repository: ambari
Updated Branches:
  refs/heads/branch-2.4 39adbe3a6 -> 13fe7434d


AMBARI-18357. Ambari fails to start nodemanager due to unexpected return code 
from sudo su command on the pid file (aonishuk)


Project: http://git-wip-us.apache.org/repos/asf/ambari/repo
Commit: http://git-wip-us.apache.org/repos/asf/ambari/commit/13fe7434
Tree: http://git-wip-us.apache.org/repos/asf/ambari/tree/13fe7434
Diff: http://git-wip-us.apache.org/repos/asf/ambari/diff/13fe7434

Branch: refs/heads/branch-2.4
Commit: 13fe7434d729932cad475493ffa8975ff3750320
Parents: 39adbe3
Author: Andrew Onishuk <[email protected]>
Authored: Wed Nov 2 13:26:10 2016 +0200
Committer: Andrew Onishuk <[email protected]>
Committed: Wed Nov 2 13:26:10 2016 +0200

----------------------------------------------------------------------
 .../YARN/2.1.0.2.0/package/scripts/service.py   |  4 ++--
 .../stacks/2.0.6/YARN/test_historyserver.py     | 18 ++++++++----------
 .../stacks/2.0.6/YARN/test_nodemanager.py       | 20 ++++++++------------
 .../stacks/2.0.6/YARN/test_resourcemanager.py   | 19 +++++++++----------
 .../stacks/2.1/YARN/test_apptimelineserver.py   | 20 +++++++++-----------
 5 files changed, 36 insertions(+), 45 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/ambari/blob/13fe7434/ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service.py
----------------------------------------------------------------------
diff --git 
a/ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service.py
 
b/ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service.py
index b1179b9..03b66a5 100644
--- 
a/ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service.py
+++ 
b/ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service.py
@@ -22,7 +22,7 @@ Ambari Agent
 from resource_management import *
 from ambari_commons.os_family_impl import OsFamilyFuncImpl, OsFamilyImpl
 from ambari_commons import OSConst
-from resource_management.core.shell import as_user
+from resource_management.core.shell import as_user, as_sudo
 from resource_management.libraries.functions.show_logs import show_logs
 
 @OsFamilyFuncImpl(os_family=OSConst.WINSRV_FAMILY)
@@ -59,7 +59,7 @@ def service(componentName, action='start', 
serviceName='yarn'):
 
   if action == 'start':
     daemon_cmd = format("{ulimit_cmd} {cmd} start {componentName}")
-    check_process = as_user(format("ls {pid_file} && ps -p `cat {pid_file}`"), 
user=usr)
+    check_process = as_sudo(["test", "-f", pid_file]) + " && " + 
as_sudo(["pgrep", "-F", pid_file])
 
     # Remove the pid file if its corresponding process is not running.
     File(pid_file, action = "delete", not_if = check_process)

http://git-wip-us.apache.org/repos/asf/ambari/blob/13fe7434/ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py
----------------------------------------------------------------------
diff --git 
a/ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 
b/ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py
index 4600063..96dfa0f 100644
--- a/ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py
+++ b/ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py
@@ -114,14 +114,14 @@ class TestHistoryServer(RMFTestCase):
 
     self.assertResourceCalled('File', 
'/var/run/hadoop-mapreduce/mapred/mapred-mapred-historyserver.pid',
         action = ['delete'],
-        not_if = "ambari-sudo.sh su mapred -l -s /bin/bash -c 
'[RMF_EXPORT_PLACEHOLDER]ls 
/var/run/hadoop-mapreduce/mapred/mapred-mapred-historyserver.pid && ps -p `cat 
/var/run/hadoop-mapreduce/mapred/mapred-mapred-historyserver.pid`'",
+        not_if = 'ambari-sudo.sh [RMF_ENV_PLACEHOLDER] -H -E test -f 
/var/run/hadoop-mapreduce/mapred/mapred-mapred-historyserver.pid && 
ambari-sudo.sh [RMF_ENV_PLACEHOLDER] -H -E pgrep -F 
/var/run/hadoop-mapreduce/mapred/mapred-mapred-historyserver.pid',
     )
     self.assertResourceCalled('Execute', 'ulimit -c unlimited; export 
HADOOP_LIBEXEC_DIR=/usr/lib/hadoop/libexec && 
/usr/lib/hadoop-mapreduce/sbin/mr-jobhistory-daemon.sh --config 
/etc/hadoop/conf start historyserver',
-        not_if = "ambari-sudo.sh su mapred -l -s /bin/bash -c 
'[RMF_EXPORT_PLACEHOLDER]ls 
/var/run/hadoop-mapreduce/mapred/mapred-mapred-historyserver.pid && ps -p `cat 
/var/run/hadoop-mapreduce/mapred/mapred-mapred-historyserver.pid`'",
+        not_if = 'ambari-sudo.sh [RMF_ENV_PLACEHOLDER] -H -E test -f 
/var/run/hadoop-mapreduce/mapred/mapred-mapred-historyserver.pid && 
ambari-sudo.sh [RMF_ENV_PLACEHOLDER] -H -E pgrep -F 
/var/run/hadoop-mapreduce/mapred/mapred-mapred-historyserver.pid',
         user = 'mapred',
     )
-    self.assertResourceCalled('Execute', "ambari-sudo.sh su mapred -l -s 
/bin/bash -c '[RMF_EXPORT_PLACEHOLDER]ls 
/var/run/hadoop-mapreduce/mapred/mapred-mapred-historyserver.pid && ps -p `cat 
/var/run/hadoop-mapreduce/mapred/mapred-mapred-historyserver.pid`'",
-        not_if = "ambari-sudo.sh su mapred -l -s /bin/bash -c 
'[RMF_EXPORT_PLACEHOLDER]ls 
/var/run/hadoop-mapreduce/mapred/mapred-mapred-historyserver.pid && ps -p `cat 
/var/run/hadoop-mapreduce/mapred/mapred-mapred-historyserver.pid`'",
+    self.assertResourceCalled('Execute', 'ambari-sudo.sh [RMF_ENV_PLACEHOLDER] 
-H -E test -f /var/run/hadoop-mapreduce/mapred/mapred-mapred-historyserver.pid 
&& ambari-sudo.sh [RMF_ENV_PLACEHOLDER] -H -E pgrep -F 
/var/run/hadoop-mapreduce/mapred/mapred-mapred-historyserver.pid',
+        not_if = 'ambari-sudo.sh [RMF_ENV_PLACEHOLDER] -H -E test -f 
/var/run/hadoop-mapreduce/mapred/mapred-mapred-historyserver.pid && 
ambari-sudo.sh [RMF_ENV_PLACEHOLDER] -H -E pgrep -F 
/var/run/hadoop-mapreduce/mapred/mapred-mapred-historyserver.pid',
         tries = 5,
         try_sleep = 1,
     )
@@ -165,18 +165,16 @@ class TestHistoryServer(RMFTestCase):
 
     self.assert_configure_secured()
 
-    pid_check_cmd = 'ls 
/var/run/hadoop-mapreduce/mapred/mapred-mapred-historyserver.pid >/dev/null 
2>&1 && ps -p `cat 
/var/run/hadoop-mapreduce/mapred/mapred-mapred-historyserver.pid` >/dev/null 
2>&1'
-
     self.assertResourceCalled('File', 
'/var/run/hadoop-mapreduce/mapred/mapred-mapred-historyserver.pid',
         action = ['delete'],
-        not_if = "ambari-sudo.sh su mapred -l -s /bin/bash -c 
'[RMF_EXPORT_PLACEHOLDER]ls 
/var/run/hadoop-mapreduce/mapred/mapred-mapred-historyserver.pid && ps -p `cat 
/var/run/hadoop-mapreduce/mapred/mapred-mapred-historyserver.pid`'",
+        not_if = 'ambari-sudo.sh [RMF_ENV_PLACEHOLDER] -H -E test -f 
/var/run/hadoop-mapreduce/mapred/mapred-mapred-historyserver.pid && 
ambari-sudo.sh [RMF_ENV_PLACEHOLDER] -H -E pgrep -F 
/var/run/hadoop-mapreduce/mapred/mapred-mapred-historyserver.pid',
     )
     self.assertResourceCalled('Execute', 'ulimit -c unlimited; export 
HADOOP_LIBEXEC_DIR=/usr/lib/hadoop/libexec && 
/usr/lib/hadoop-mapreduce/sbin/mr-jobhistory-daemon.sh --config 
/etc/hadoop/conf start historyserver',
-        not_if = "ambari-sudo.sh su mapred -l -s /bin/bash -c 
'[RMF_EXPORT_PLACEHOLDER]ls 
/var/run/hadoop-mapreduce/mapred/mapred-mapred-historyserver.pid && ps -p `cat 
/var/run/hadoop-mapreduce/mapred/mapred-mapred-historyserver.pid`'",
+        not_if = 'ambari-sudo.sh [RMF_ENV_PLACEHOLDER] -H -E test -f 
/var/run/hadoop-mapreduce/mapred/mapred-mapred-historyserver.pid && 
ambari-sudo.sh [RMF_ENV_PLACEHOLDER] -H -E pgrep -F 
/var/run/hadoop-mapreduce/mapred/mapred-mapred-historyserver.pid',
         user = 'mapred',
     )
-    self.assertResourceCalled('Execute', "ambari-sudo.sh su mapred -l -s 
/bin/bash -c '[RMF_EXPORT_PLACEHOLDER]ls 
/var/run/hadoop-mapreduce/mapred/mapred-mapred-historyserver.pid && ps -p `cat 
/var/run/hadoop-mapreduce/mapred/mapred-mapred-historyserver.pid`'",
-        not_if = "ambari-sudo.sh su mapred -l -s /bin/bash -c 
'[RMF_EXPORT_PLACEHOLDER]ls 
/var/run/hadoop-mapreduce/mapred/mapred-mapred-historyserver.pid && ps -p `cat 
/var/run/hadoop-mapreduce/mapred/mapred-mapred-historyserver.pid`'",
+    self.assertResourceCalled('Execute', 'ambari-sudo.sh [RMF_ENV_PLACEHOLDER] 
-H -E test -f /var/run/hadoop-mapreduce/mapred/mapred-mapred-historyserver.pid 
&& ambari-sudo.sh [RMF_ENV_PLACEHOLDER] -H -E pgrep -F 
/var/run/hadoop-mapreduce/mapred/mapred-mapred-historyserver.pid',
+        not_if = 'ambari-sudo.sh [RMF_ENV_PLACEHOLDER] -H -E test -f 
/var/run/hadoop-mapreduce/mapred/mapred-mapred-historyserver.pid && 
ambari-sudo.sh [RMF_ENV_PLACEHOLDER] -H -E pgrep -F 
/var/run/hadoop-mapreduce/mapred/mapred-mapred-historyserver.pid',
         tries = 5,
         try_sleep = 1,
     )

http://git-wip-us.apache.org/repos/asf/ambari/blob/13fe7434/ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py
----------------------------------------------------------------------
diff --git 
a/ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 
b/ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py
index 06b976e..4abf2c9 100644
--- a/ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py
+++ b/ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py
@@ -55,18 +55,16 @@ class TestNodeManager(RMFTestCase):
     )
     self.assert_configure_default()
 
-    pid_check_cmd = 'ls /var/run/hadoop-yarn/yarn/yarn-yarn-nodemanager.pid 
>/dev/null 2>&1 && ps -p `cat 
/var/run/hadoop-yarn/yarn/yarn-yarn-nodemanager.pid` >/dev/null 2>&1'
-
     self.assertResourceCalled('File', 
'/var/run/hadoop-yarn/yarn/yarn-yarn-nodemanager.pid',
         action = ['delete'],
-        not_if = "ambari-sudo.sh su yarn -l -s /bin/bash -c 
'[RMF_EXPORT_PLACEHOLDER]ls /var/run/hadoop-yarn/yarn/yarn-yarn-nodemanager.pid 
&& ps -p `cat /var/run/hadoop-yarn/yarn/yarn-yarn-nodemanager.pid`'",
+        not_if = 'ambari-sudo.sh [RMF_ENV_PLACEHOLDER] -H -E test -f 
/var/run/hadoop-yarn/yarn/yarn-yarn-nodemanager.pid && ambari-sudo.sh 
[RMF_ENV_PLACEHOLDER] -H -E pgrep -F 
/var/run/hadoop-yarn/yarn/yarn-yarn-nodemanager.pid',
     )
     self.assertResourceCalled('Execute', 'ulimit -c unlimited; export 
HADOOP_LIBEXEC_DIR=/usr/lib/hadoop/libexec && 
/usr/lib/hadoop-yarn/sbin/yarn-daemon.sh --config /etc/hadoop/conf start 
nodemanager',
-        not_if = "ambari-sudo.sh su yarn -l -s /bin/bash -c 
'[RMF_EXPORT_PLACEHOLDER]ls /var/run/hadoop-yarn/yarn/yarn-yarn-nodemanager.pid 
&& ps -p `cat /var/run/hadoop-yarn/yarn/yarn-yarn-nodemanager.pid`'",
+        not_if = 'ambari-sudo.sh [RMF_ENV_PLACEHOLDER] -H -E test -f 
/var/run/hadoop-yarn/yarn/yarn-yarn-nodemanager.pid && ambari-sudo.sh 
[RMF_ENV_PLACEHOLDER] -H -E pgrep -F 
/var/run/hadoop-yarn/yarn/yarn-yarn-nodemanager.pid',
         user = 'yarn',
     )
-    self.assertResourceCalled('Execute', "ambari-sudo.sh su yarn -l -s 
/bin/bash -c '[RMF_EXPORT_PLACEHOLDER]ls 
/var/run/hadoop-yarn/yarn/yarn-yarn-nodemanager.pid && ps -p `cat 
/var/run/hadoop-yarn/yarn/yarn-yarn-nodemanager.pid`'",
-        not_if = "ambari-sudo.sh su yarn -l -s /bin/bash -c 
'[RMF_EXPORT_PLACEHOLDER]ls /var/run/hadoop-yarn/yarn/yarn-yarn-nodemanager.pid 
&& ps -p `cat /var/run/hadoop-yarn/yarn/yarn-yarn-nodemanager.pid`'",
+    self.assertResourceCalled('Execute', 'ambari-sudo.sh [RMF_ENV_PLACEHOLDER] 
-H -E test -f /var/run/hadoop-yarn/yarn/yarn-yarn-nodemanager.pid && 
ambari-sudo.sh [RMF_ENV_PLACEHOLDER] -H -E pgrep -F 
/var/run/hadoop-yarn/yarn/yarn-yarn-nodemanager.pid',
+        not_if = 'ambari-sudo.sh [RMF_ENV_PLACEHOLDER] -H -E test -f 
/var/run/hadoop-yarn/yarn/yarn-yarn-nodemanager.pid && ambari-sudo.sh 
[RMF_ENV_PLACEHOLDER] -H -E pgrep -F 
/var/run/hadoop-yarn/yarn/yarn-yarn-nodemanager.pid',
         tries = 5,
         try_sleep = 1,
     )
@@ -107,18 +105,16 @@ class TestNodeManager(RMFTestCase):
 
     self.assert_configure_secured()
 
-    pid_check_cmd = 'ls /var/run/hadoop-yarn/yarn/yarn-yarn-nodemanager.pid 
>/dev/null 2>&1 && ps -p `cat 
/var/run/hadoop-yarn/yarn/yarn-yarn-nodemanager.pid` >/dev/null 2>&1'
-
     self.assertResourceCalled('File', 
'/var/run/hadoop-yarn/yarn/yarn-yarn-nodemanager.pid',
         action = ['delete'],
-        not_if = "ambari-sudo.sh su yarn -l -s /bin/bash -c 
'[RMF_EXPORT_PLACEHOLDER]ls /var/run/hadoop-yarn/yarn/yarn-yarn-nodemanager.pid 
&& ps -p `cat /var/run/hadoop-yarn/yarn/yarn-yarn-nodemanager.pid`'",
+        not_if = 'ambari-sudo.sh [RMF_ENV_PLACEHOLDER] -H -E test -f 
/var/run/hadoop-yarn/yarn/yarn-yarn-nodemanager.pid && ambari-sudo.sh 
[RMF_ENV_PLACEHOLDER] -H -E pgrep -F 
/var/run/hadoop-yarn/yarn/yarn-yarn-nodemanager.pid',
     )
     self.assertResourceCalled('Execute', 'ulimit -c unlimited; export 
HADOOP_LIBEXEC_DIR=/usr/lib/hadoop/libexec && 
/usr/lib/hadoop-yarn/sbin/yarn-daemon.sh --config /etc/hadoop/conf start 
nodemanager',
-        not_if = "ambari-sudo.sh su yarn -l -s /bin/bash -c 
'[RMF_EXPORT_PLACEHOLDER]ls /var/run/hadoop-yarn/yarn/yarn-yarn-nodemanager.pid 
&& ps -p `cat /var/run/hadoop-yarn/yarn/yarn-yarn-nodemanager.pid`'",
+        not_if = 'ambari-sudo.sh [RMF_ENV_PLACEHOLDER] -H -E test -f 
/var/run/hadoop-yarn/yarn/yarn-yarn-nodemanager.pid && ambari-sudo.sh 
[RMF_ENV_PLACEHOLDER] -H -E pgrep -F 
/var/run/hadoop-yarn/yarn/yarn-yarn-nodemanager.pid',
         user = 'yarn',
     )
-    self.assertResourceCalled('Execute', "ambari-sudo.sh su yarn -l -s 
/bin/bash -c '[RMF_EXPORT_PLACEHOLDER]ls 
/var/run/hadoop-yarn/yarn/yarn-yarn-nodemanager.pid && ps -p `cat 
/var/run/hadoop-yarn/yarn/yarn-yarn-nodemanager.pid`'",
-        not_if = "ambari-sudo.sh su yarn -l -s /bin/bash -c 
'[RMF_EXPORT_PLACEHOLDER]ls /var/run/hadoop-yarn/yarn/yarn-yarn-nodemanager.pid 
&& ps -p `cat /var/run/hadoop-yarn/yarn/yarn-yarn-nodemanager.pid`'",
+    self.assertResourceCalled('Execute', 'ambari-sudo.sh [RMF_ENV_PLACEHOLDER] 
-H -E test -f /var/run/hadoop-yarn/yarn/yarn-yarn-nodemanager.pid && 
ambari-sudo.sh [RMF_ENV_PLACEHOLDER] -H -E pgrep -F 
/var/run/hadoop-yarn/yarn/yarn-yarn-nodemanager.pid',
+        not_if = 'ambari-sudo.sh [RMF_ENV_PLACEHOLDER] -H -E test -f 
/var/run/hadoop-yarn/yarn/yarn-yarn-nodemanager.pid && ambari-sudo.sh 
[RMF_ENV_PLACEHOLDER] -H -E pgrep -F 
/var/run/hadoop-yarn/yarn/yarn-yarn-nodemanager.pid',
         tries = 5,
         try_sleep = 1,
     )

http://git-wip-us.apache.org/repos/asf/ambari/blob/13fe7434/ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py
----------------------------------------------------------------------
diff --git 
a/ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py 
b/ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py
index a0e65cd..7b5ce18 100644
--- a/ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py
+++ b/ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py
@@ -58,17 +58,17 @@ class TestResourceManager(RMFTestCase):
     )
 
     self.assert_configure_default()
-
+    
     self.assertResourceCalled('File', 
'/var/run/hadoop-yarn/yarn/yarn-yarn-resourcemanager.pid',
         action = ['delete'],
-        not_if = "ambari-sudo.sh su yarn -l -s /bin/bash -c 
'[RMF_EXPORT_PLACEHOLDER]ls 
/var/run/hadoop-yarn/yarn/yarn-yarn-resourcemanager.pid && ps -p `cat 
/var/run/hadoop-yarn/yarn/yarn-yarn-resourcemanager.pid`'",
+        not_if = 'ambari-sudo.sh [RMF_ENV_PLACEHOLDER] -H -E test -f 
/var/run/hadoop-yarn/yarn/yarn-yarn-resourcemanager.pid && ambari-sudo.sh 
[RMF_ENV_PLACEHOLDER] -H -E pgrep -F 
/var/run/hadoop-yarn/yarn/yarn-yarn-resourcemanager.pid',
     )
     self.assertResourceCalled('Execute', 'ulimit -c unlimited; export 
HADOOP_LIBEXEC_DIR=/usr/lib/hadoop/libexec && 
/usr/lib/hadoop-yarn/sbin/yarn-daemon.sh --config /etc/hadoop/conf start 
resourcemanager',
-        not_if = "ambari-sudo.sh su yarn -l -s /bin/bash -c 
'[RMF_EXPORT_PLACEHOLDER]ls 
/var/run/hadoop-yarn/yarn/yarn-yarn-resourcemanager.pid && ps -p `cat 
/var/run/hadoop-yarn/yarn/yarn-yarn-resourcemanager.pid`'",
+        not_if = 'ambari-sudo.sh [RMF_ENV_PLACEHOLDER] -H -E test -f 
/var/run/hadoop-yarn/yarn/yarn-yarn-resourcemanager.pid && ambari-sudo.sh 
[RMF_ENV_PLACEHOLDER] -H -E pgrep -F 
/var/run/hadoop-yarn/yarn/yarn-yarn-resourcemanager.pid',
         user = 'yarn',
     )
-    self.assertResourceCalled('Execute', "ambari-sudo.sh su yarn -l -s 
/bin/bash -c '[RMF_EXPORT_PLACEHOLDER]ls 
/var/run/hadoop-yarn/yarn/yarn-yarn-resourcemanager.pid && ps -p `cat 
/var/run/hadoop-yarn/yarn/yarn-yarn-resourcemanager.pid`'",
-        not_if = "ambari-sudo.sh su yarn -l -s /bin/bash -c 
'[RMF_EXPORT_PLACEHOLDER]ls 
/var/run/hadoop-yarn/yarn/yarn-yarn-resourcemanager.pid && ps -p `cat 
/var/run/hadoop-yarn/yarn/yarn-yarn-resourcemanager.pid`'",
+    self.assertResourceCalled('Execute', 'ambari-sudo.sh [RMF_ENV_PLACEHOLDER] 
-H -E test -f /var/run/hadoop-yarn/yarn/yarn-yarn-resourcemanager.pid && 
ambari-sudo.sh [RMF_ENV_PLACEHOLDER] -H -E pgrep -F 
/var/run/hadoop-yarn/yarn/yarn-yarn-resourcemanager.pid',
+        not_if = 'ambari-sudo.sh [RMF_ENV_PLACEHOLDER] -H -E test -f 
/var/run/hadoop-yarn/yarn/yarn-yarn-resourcemanager.pid && ambari-sudo.sh 
[RMF_ENV_PLACEHOLDER] -H -E pgrep -F 
/var/run/hadoop-yarn/yarn/yarn-yarn-resourcemanager.pid',
         tries = 5,
         try_sleep = 1,
     )
@@ -109,17 +109,16 @@ class TestResourceManager(RMFTestCase):
 
     self.assert_configure_secured()
 
-    pid_check_cmd = 'ls 
/var/run/hadoop-yarn/yarn/yarn-yarn-resourcemanager.pid >/dev/null 2>&1 && ps 
-p `cat /var/run/hadoop-yarn/yarn/yarn-yarn-resourcemanager.pid` >/dev/null 
2>&1'
     self.assertResourceCalled('File', 
'/var/run/hadoop-yarn/yarn/yarn-yarn-resourcemanager.pid',
         action = ['delete'],
-        not_if = "ambari-sudo.sh su yarn -l -s /bin/bash -c 
'[RMF_EXPORT_PLACEHOLDER]ls 
/var/run/hadoop-yarn/yarn/yarn-yarn-resourcemanager.pid && ps -p `cat 
/var/run/hadoop-yarn/yarn/yarn-yarn-resourcemanager.pid`'",
+        not_if = 'ambari-sudo.sh [RMF_ENV_PLACEHOLDER] -H -E test -f 
/var/run/hadoop-yarn/yarn/yarn-yarn-resourcemanager.pid && ambari-sudo.sh 
[RMF_ENV_PLACEHOLDER] -H -E pgrep -F 
/var/run/hadoop-yarn/yarn/yarn-yarn-resourcemanager.pid',
     )
     self.assertResourceCalled('Execute', 'ulimit -c unlimited; export 
HADOOP_LIBEXEC_DIR=/usr/lib/hadoop/libexec && 
/usr/lib/hadoop-yarn/sbin/yarn-daemon.sh --config /etc/hadoop/conf start 
resourcemanager',
-        not_if = "ambari-sudo.sh su yarn -l -s /bin/bash -c 
'[RMF_EXPORT_PLACEHOLDER]ls 
/var/run/hadoop-yarn/yarn/yarn-yarn-resourcemanager.pid && ps -p `cat 
/var/run/hadoop-yarn/yarn/yarn-yarn-resourcemanager.pid`'",
+        not_if = 'ambari-sudo.sh [RMF_ENV_PLACEHOLDER] -H -E test -f 
/var/run/hadoop-yarn/yarn/yarn-yarn-resourcemanager.pid && ambari-sudo.sh 
[RMF_ENV_PLACEHOLDER] -H -E pgrep -F 
/var/run/hadoop-yarn/yarn/yarn-yarn-resourcemanager.pid',
         user = 'yarn',
     )
-    self.assertResourceCalled('Execute', "ambari-sudo.sh su yarn -l -s 
/bin/bash -c '[RMF_EXPORT_PLACEHOLDER]ls 
/var/run/hadoop-yarn/yarn/yarn-yarn-resourcemanager.pid && ps -p `cat 
/var/run/hadoop-yarn/yarn/yarn-yarn-resourcemanager.pid`'",
-        not_if = "ambari-sudo.sh su yarn -l -s /bin/bash -c 
'[RMF_EXPORT_PLACEHOLDER]ls 
/var/run/hadoop-yarn/yarn/yarn-yarn-resourcemanager.pid && ps -p `cat 
/var/run/hadoop-yarn/yarn/yarn-yarn-resourcemanager.pid`'",
+    self.assertResourceCalled('Execute', 'ambari-sudo.sh [RMF_ENV_PLACEHOLDER] 
-H -E test -f /var/run/hadoop-yarn/yarn/yarn-yarn-resourcemanager.pid && 
ambari-sudo.sh [RMF_ENV_PLACEHOLDER] -H -E pgrep -F 
/var/run/hadoop-yarn/yarn/yarn-yarn-resourcemanager.pid',
+        not_if = 'ambari-sudo.sh [RMF_ENV_PLACEHOLDER] -H -E test -f 
/var/run/hadoop-yarn/yarn/yarn-yarn-resourcemanager.pid && ambari-sudo.sh 
[RMF_ENV_PLACEHOLDER] -H -E pgrep -F 
/var/run/hadoop-yarn/yarn/yarn-yarn-resourcemanager.pid',
         tries = 5,
         try_sleep = 1,
     )

http://git-wip-us.apache.org/repos/asf/ambari/blob/13fe7434/ambari-server/src/test/python/stacks/2.1/YARN/test_apptimelineserver.py
----------------------------------------------------------------------
diff --git 
a/ambari-server/src/test/python/stacks/2.1/YARN/test_apptimelineserver.py 
b/ambari-server/src/test/python/stacks/2.1/YARN/test_apptimelineserver.py
index 1a0c788..7878857 100644
--- a/ambari-server/src/test/python/stacks/2.1/YARN/test_apptimelineserver.py
+++ b/ambari-server/src/test/python/stacks/2.1/YARN/test_apptimelineserver.py
@@ -55,25 +55,23 @@ class TestAppTimelineServer(RMFTestCase):
     )
 
     self.assert_configure_default()
-
+    
     self.assertResourceCalled('File', 
'/var/run/hadoop-yarn/yarn/yarn-yarn-timelineserver.pid',
         action = ['delete'],
-        not_if = "ambari-sudo.sh su yarn -l -s /bin/bash -c 
'[RMF_EXPORT_PLACEHOLDER]ls 
/var/run/hadoop-yarn/yarn/yarn-yarn-timelineserver.pid && ps -p `cat 
/var/run/hadoop-yarn/yarn/yarn-yarn-timelineserver.pid`'",
+        not_if = 'ambari-sudo.sh [RMF_ENV_PLACEHOLDER] -H -E test -f 
/var/run/hadoop-yarn/yarn/yarn-yarn-timelineserver.pid && ambari-sudo.sh 
[RMF_ENV_PLACEHOLDER] -H -E pgrep -F 
/var/run/hadoop-yarn/yarn/yarn-yarn-timelineserver.pid',
     )
-
     self.assertResourceCalled('File', 
'/var/log/hadoop-yarn/timeline/leveldb-timeline-store.ldb/LOCK',
-        only_if='ls 
/var/log/hadoop-yarn/timeline/leveldb-timeline-store.ldb/LOCK',
-        action=['delete'],
-        not_if="ambari-sudo.sh su yarn -l -s /bin/bash -c 
'[RMF_EXPORT_PLACEHOLDER]ls 
/var/run/hadoop-yarn/yarn/yarn-yarn-timelineserver.pid && ps -p `cat 
/var/run/hadoop-yarn/yarn/yarn-yarn-timelineserver.pid`'",
-        ignore_failures=True
+        action = ['delete'],
+        not_if = 'ambari-sudo.sh [RMF_ENV_PLACEHOLDER] -H -E test -f 
/var/run/hadoop-yarn/yarn/yarn-yarn-timelineserver.pid && ambari-sudo.sh 
[RMF_ENV_PLACEHOLDER] -H -E pgrep -F 
/var/run/hadoop-yarn/yarn/yarn-yarn-timelineserver.pid',
+        ignore_failures = True,
+        only_if = 'ls 
/var/log/hadoop-yarn/timeline/leveldb-timeline-store.ldb/LOCK',
     )
-
     self.assertResourceCalled('Execute', 'ulimit -c unlimited; export 
HADOOP_LIBEXEC_DIR=/usr/lib/hadoop/libexec && 
/usr/lib/hadoop-yarn/sbin/yarn-daemon.sh --config /etc/hadoop/conf start 
timelineserver',
-        not_if = "ambari-sudo.sh su yarn -l -s /bin/bash -c 
'[RMF_EXPORT_PLACEHOLDER]ls 
/var/run/hadoop-yarn/yarn/yarn-yarn-timelineserver.pid && ps -p `cat 
/var/run/hadoop-yarn/yarn/yarn-yarn-timelineserver.pid`'",
+        not_if = 'ambari-sudo.sh [RMF_ENV_PLACEHOLDER] -H -E test -f 
/var/run/hadoop-yarn/yarn/yarn-yarn-timelineserver.pid && ambari-sudo.sh 
[RMF_ENV_PLACEHOLDER] -H -E pgrep -F 
/var/run/hadoop-yarn/yarn/yarn-yarn-timelineserver.pid',
         user = 'yarn',
     )
-    self.assertResourceCalled('Execute', "ambari-sudo.sh su yarn -l -s 
/bin/bash -c '[RMF_EXPORT_PLACEHOLDER]ls 
/var/run/hadoop-yarn/yarn/yarn-yarn-timelineserver.pid && ps -p `cat 
/var/run/hadoop-yarn/yarn/yarn-yarn-timelineserver.pid`'",
-        not_if = "ambari-sudo.sh su yarn -l -s /bin/bash -c 
'[RMF_EXPORT_PLACEHOLDER]ls 
/var/run/hadoop-yarn/yarn/yarn-yarn-timelineserver.pid && ps -p `cat 
/var/run/hadoop-yarn/yarn/yarn-yarn-timelineserver.pid`'",
+    self.assertResourceCalled('Execute', 'ambari-sudo.sh [RMF_ENV_PLACEHOLDER] 
-H -E test -f /var/run/hadoop-yarn/yarn/yarn-yarn-timelineserver.pid && 
ambari-sudo.sh [RMF_ENV_PLACEHOLDER] -H -E pgrep -F 
/var/run/hadoop-yarn/yarn/yarn-yarn-timelineserver.pid',
+        not_if = 'ambari-sudo.sh [RMF_ENV_PLACEHOLDER] -H -E test -f 
/var/run/hadoop-yarn/yarn/yarn-yarn-timelineserver.pid && ambari-sudo.sh 
[RMF_ENV_PLACEHOLDER] -H -E pgrep -F 
/var/run/hadoop-yarn/yarn/yarn-yarn-timelineserver.pid',
         tries = 5,
         try_sleep = 1,
     )

Reply via email to