Repository: ambari
Updated Branches:
  refs/heads/branch-2.5 45c9b7916 -> 5eedeaec9


AMBARI-19354 : Invalid message is shown after saving the workflow (Padma Priya 
via nitirajrathore)


Project: http://git-wip-us.apache.org/repos/asf/ambari/repo
Commit: http://git-wip-us.apache.org/repos/asf/ambari/commit/5eedeaec
Tree: http://git-wip-us.apache.org/repos/asf/ambari/tree/5eedeaec
Diff: http://git-wip-us.apache.org/repos/asf/ambari/diff/5eedeaec

Branch: refs/heads/branch-2.5
Commit: 5eedeaec9be1a2ee94e6bd5bce451ad81dca3233
Parents: 45c9b79
Author: Nitiraj Rathore <[email protected]>
Authored: Fri Jan 6 18:34:31 2017 +0530
Committer: Nitiraj Rathore <[email protected]>
Committed: Fri Jan 6 18:34:31 2017 +0530

----------------------------------------------------------------------
 .../src/main/resources/ui/app/components/flow-designer.js          | 2 +-
 .../src/main/resources/ui/app/domain/workflow-path-util.js         | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/ambari/blob/5eedeaec/contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js
----------------------------------------------------------------------
diff --git 
a/contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
b/contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js
index 66123d0..2dd60a0 100644
--- 
a/contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js
+++ 
b/contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js
@@ -848,7 +848,7 @@ export default Ember.Component.extend(FindNodeMixin, 
Validations, {
         this.set('currentNode.errorNode', transition.errorNode);
       }
       currentNode.transitions.forEach((trans)=>{
-        if(transition.okToNode){
+        if(transition.okToNode && trans.condition !== 'error'){
           if(trans.targetNode.id !== transition.okToNode.id){
             trans.targetNode = transition.okToNode;
             this.showUndo('transition');

http://git-wip-us.apache.org/repos/asf/ambari/blob/5eedeaec/contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-path-util.js
----------------------------------------------------------------------
diff --git 
a/contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-path-util.js
 
b/contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-path-util.js
index c921455..431b59b 100644
--- 
a/contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-path-util.js
+++ 
b/contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-path-util.js
@@ -66,7 +66,7 @@ export default Ember.Object.create({
       }, this);
     }, this);
     validTransitionsTo = validTransitionsTo.reject((node)=>{
-      return node.get('type') === 'placeholder';
+      return node.get('type') === 'placeholder' || node.get('type') === 'kill';
     }, this);
     return validTransitionsTo;
   }

Reply via email to