AMBARI-19540. Possibly too frequent calls to stack advisor as user changes sliders (alexantonenko)
Project: http://git-wip-us.apache.org/repos/asf/ambari/repo Commit: http://git-wip-us.apache.org/repos/asf/ambari/commit/e60ac672 Tree: http://git-wip-us.apache.org/repos/asf/ambari/tree/e60ac672 Diff: http://git-wip-us.apache.org/repos/asf/ambari/diff/e60ac672 Branch: refs/heads/branch-2.5 Commit: e60ac672007d11daacfb02d119c5d35249b5bf5f Parents: 38e0b57 Author: Alex Antonenko <[email protected]> Authored: Mon Jan 16 20:31:36 2017 +0200 Committer: Alex Antonenko <[email protected]> Committed: Mon Jan 16 20:36:37 2017 +0200 ---------------------------------------------------------------------- ambari-web/app/templates/common/configs/widgets/controls.hbs | 8 +++++++- ambari-web/app/views/common/controls_view.js | 3 ++- 2 files changed, 9 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/ambari/blob/e60ac672/ambari-web/app/templates/common/configs/widgets/controls.hbs ---------------------------------------------------------------------- diff --git a/ambari-web/app/templates/common/configs/widgets/controls.hbs b/ambari-web/app/templates/common/configs/widgets/controls.hbs index f51f7e8..af5a56a 100644 --- a/ambari-web/app/templates/common/configs/widgets/controls.hbs +++ b/ambari-web/app/templates/common/configs/widgets/controls.hbs @@ -22,7 +22,13 @@ {{#if view.supportSwitchToTextBox}} {{#unless view.isPropertyUndefined}} <div {{bindAttr class="view.config.showAsTextBox::hide :left :widget-config-raw"}}> - {{view App.PlainConfigTextField sectionBinding="view.section" subSectionBinding="view.subSection" configBinding="view.config" serviceConfigBinding="view.config" disabledBinding="view.canNotEdit"}} + {{view App.PlainConfigTextField + isVisibleBinding="view.config.showAsTextBox" + sectionBinding="view.section" + subSectionBinding="view.subSection" + configBinding="view.config" + serviceConfigBinding="view.config" + disabledBinding="view.canNotEdit"}} </div> {{/unless}} {{/if}} http://git-wip-us.apache.org/repos/asf/ambari/blob/e60ac672/ambari-web/app/views/common/controls_view.js ---------------------------------------------------------------------- diff --git a/ambari-web/app/views/common/controls_view.js b/ambari-web/app/views/common/controls_view.js index dc91f36..44d0d2f 100644 --- a/ambari-web/app/views/common/controls_view.js +++ b/ambari-web/app/views/common/controls_view.js @@ -101,7 +101,7 @@ App.SupportsDependentConfigs = Ember.Mixin.create({ var type = App.config.getConfigTagFromFileName(config.get('filename')); var p = App.configsCollection.getConfig(App.config.configId(name, type)); controller.removeCurrentFromDependentList(config, saveRecommended); - if ((p && Em.get(p, 'propertyDependedBy.length') > 0) + if ((p && Em.get(p, 'propertyDependedBy.length') > 0) || (config.get('displayType') === 'user' && config.get('oldValue') !== config.get('value'))) { var old = config.get('oldValue'); config.set('oldValue', config.get('value')); @@ -156,6 +156,7 @@ App.SupportsDependentConfigs = Ember.Mixin.create({ App.ValueObserver = Em.Mixin.create(App.SupportsDependentConfigs, { onValueUpdate: function () { + if (!this.get('isVisible')) return; var self = this, config = this.get('serviceConfig'), controller = this.get('controller'); delay(function(){
