AMBARI-20104 : Kafka Controller metrics are not being displayed. (avijayan)
Project: http://git-wip-us.apache.org/repos/asf/ambari/repo Commit: http://git-wip-us.apache.org/repos/asf/ambari/commit/ef0ae8bf Tree: http://git-wip-us.apache.org/repos/asf/ambari/tree/ef0ae8bf Diff: http://git-wip-us.apache.org/repos/asf/ambari/diff/ef0ae8bf Branch: refs/heads/branch-feature-AMBARI-12556 Commit: ef0ae8bfdbe515851ddcec3139db0250b1cc62df Parents: 235f526 Author: Aravindan Vijayan <[email protected]> Authored: Tue Feb 21 16:06:55 2017 -0800 Committer: Aravindan Vijayan <[email protected]> Committed: Tue Feb 21 16:06:55 2017 -0800 ---------------------------------------------------------------------- ambari-metrics/ambari-metrics-kafka-sink/pom.xml | 7 ++++++- .../metrics2/sink/kafka/KafkaTimelineMetricsReporter.java | 9 ++++++--- 2 files changed, 12 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/ambari/blob/ef0ae8bf/ambari-metrics/ambari-metrics-kafka-sink/pom.xml ---------------------------------------------------------------------- diff --git a/ambari-metrics/ambari-metrics-kafka-sink/pom.xml b/ambari-metrics/ambari-metrics-kafka-sink/pom.xml index 89700cc..91f8fe7 100644 --- a/ambari-metrics/ambari-metrics-kafka-sink/pom.xml +++ b/ambari-metrics/ambari-metrics-kafka-sink/pom.xml @@ -144,7 +144,7 @@ limitations under the License. <dependency> <groupId>org.apache.kafka</groupId> <artifactId>kafka_2.10</artifactId> - <version>0.8.1.1</version> + <version>0.10.1.0</version> <exclusions> <exclusion> <groupId>com.sun.jdmk</groupId> @@ -169,6 +169,11 @@ limitations under the License. </exclusions> </dependency> <dependency> + <groupId>org.apache.kafka</groupId> + <artifactId>kafka-clients</artifactId> + <version>0.10.1.0</version> + </dependency> + <dependency> <groupId>com.yammer.metrics</groupId> <artifactId>metrics-core</artifactId> <version>2.2.0</version> http://git-wip-us.apache.org/repos/asf/ambari/blob/ef0ae8bf/ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java ---------------------------------------------------------------------- diff --git a/ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java b/ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java index b9ca9f5..9d492cb 100644 --- a/ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java +++ b/ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java @@ -378,9 +378,12 @@ public class KafkaTimelineMetricsReporter extends AbstractTimelineMetricsSink final long currentTimeMillis = System.currentTimeMillis(); final String sanitizedName = sanitizeName(name); - cacheSanitizedTimelineMetric(currentTimeMillis, sanitizedName, "", Double.parseDouble(String.valueOf(gauge.value()))); - - populateMetricsList(context, MetricType.GAUGE, sanitizedName); + try { + cacheSanitizedTimelineMetric(currentTimeMillis, sanitizedName, "", Double.parseDouble(String.valueOf(gauge.value()))); + populateMetricsList(context, MetricType.GAUGE, sanitizedName); + } catch (NumberFormatException ex) { + LOG.debug(ex.getMessage()); + } } private String[] cacheKafkaMetered(long currentTimeMillis, String sanitizedName, Metered meter) {
