Repository: ambari Updated Branches: refs/heads/trunk afb9a66e2 -> 0c6cf8147
AMBARI-22301. HOU: Service desired repo versions are not being set (ncole) Project: http://git-wip-us.apache.org/repos/asf/ambari/repo Commit: http://git-wip-us.apache.org/repos/asf/ambari/commit/0c6cf814 Tree: http://git-wip-us.apache.org/repos/asf/ambari/tree/0c6cf814 Diff: http://git-wip-us.apache.org/repos/asf/ambari/diff/0c6cf814 Branch: refs/heads/trunk Commit: 0c6cf8147d657923fec1c4f5fe8a234117689052 Parents: afb9a66 Author: Nate Cole <[email protected]> Authored: Fri Nov 3 16:18:45 2017 -0400 Committer: Nate Cole <[email protected]> Committed: Fri Nov 3 16:18:45 2017 -0400 ---------------------------------------------------------------------- .../server/controller/internal/UpgradeResourceProvider.java | 4 ++-- .../controller/internal/UpgradeResourceProviderTest.java | 8 ++++++++ 2 files changed, 10 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/ambari/blob/0c6cf814/ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java ---------------------------------------------------------------------- diff --git a/ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java b/ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java index a1ec98a..14b1b86 100644 --- a/ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java +++ b/ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java @@ -762,11 +762,11 @@ public class UpgradeResourceProvider extends AbstractControllerResourceProvider The Upgrade Pack is responsible for calling {@link org.apache.ambari.server.serveraction.upgrades.UpdateDesiredRepositoryAction} at the appropriate moment during the orchestration. */ - if (pack.getType() == UpgradeType.ROLLING) { + if (pack.getType() == UpgradeType.ROLLING || pack.getType() == UpgradeType.HOST_ORDERED) { s_upgradeHelper.updateDesiredRepositoriesAndConfigs(upgradeContext); } - @Experimental(feature = ExperimentalFeature.PATCH_UPGRADES, comment = "This is wrong") + @Experimental(feature = ExperimentalFeature.PATCH_UPGRADES, comment = "This is SO VERY wrong") StackId configurationPackSourceStackId = upgradeContext.getSourceVersions().values().iterator().next().getStackId(); // resolve or build a proper config upgrade pack - always start out with the config pack http://git-wip-us.apache.org/repos/asf/ambari/blob/0c6cf814/ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java ---------------------------------------------------------------------- diff --git a/ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java b/ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java index d6b1ab3..64d416f 100644 --- a/ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java +++ b/ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java @@ -1443,6 +1443,14 @@ public class UpgradeResourceProviderTest extends EasyMockSupport { requestProps.put(UpgradeResourceProvider.UPGRADE_HOST_ORDERED_HOSTS, hostsOrder); upgradeResourceProvider.createResources(request); + + + // make sure that the desired versions are updated + Cluster cluster = clusters.getCluster("c1"); + assertNotNull(cluster); + + Service service = cluster.getService("ZOOKEEPER"); + assertEquals(repoVersionEntity2200, service.getDesiredRepositoryVersion()); } /**
