This is an automated email from the ASF dual-hosted git repository.
jgolieb pushed a commit to branch branch-feature-AMBARI-14714-mpack-advisor
in repository https://gitbox.apache.org/repos/asf/ambari.git
The following commit(s) were added to
refs/heads/branch-feature-AMBARI-14714-mpack-advisor by this push:
new 10e0d33 Merge from main feature branch. (#1485)
10e0d33 is described below
commit 10e0d33d25b78d32348bccd36c28a41832ae2cd6
Author: Jason Golieb <[email protected]>
AuthorDate: Thu Jun 7 09:27:51 2018 -0400
Merge from main feature branch. (#1485)
* Remove references to deleted unit test files and fix broken tests.
* [AMBARI-23969] UI should load stack services from multiple mpacks. (#1403)
* [AMBARI-23969] UI should load stack services from multiple mpacks.
* Removed stack version number
* AMBARI-23972. Update code for : (1). 'mpack-recommendations' directory
creation and (2). putting 'mpack_advisor_wrapper.py' in
'/var/lib/ambari-server/resources/scripts/' folder.
* AMBARI-14714. Fix some unit tests
* AMBARI-14714. Fix ServiceResourceProviderTest
* AMBARI-23746. Cannot create same named service in different service
groups in same request
* AMBARI-23746. Cannot create same named component in different service
groups in same request
* AMBARI-22875. Service group name mismatch
* AMBARI-23746. Cannot query services with same name
* AMBARI-23746. Use List for componentID duplicate check
* AMBARI-23987. Set 'skip.service.checks' = true during deploy.
* Clear clusterData when user is not logged in.
* [AMBARI-23993] Mpack Instance Manager should create pid dir and log dir
for each instance (#1424)
* AMBARI-23993: Mpack Instance Manager should create pid dir and log dir
for each instance
* AMBARI-23993: Mpack Instance Manager should create pid dir and log dir
for each instance
* AMBARI-23993-2: Mpack Instance Manager should create pid dir and log dir
for each instance: add get_log_dir and get_run_dir to import
* AMBARI-23999 Remove hardcoded logic in UI to create HDPCORE service group
and create multiple service groups
* AMBARI-24011: Add workaround to hide client modules in the dashboard
(jluniya) (#1443)
Change-Id: Ie69b4e0ca654d59952807694cf2f3f24d6b74c0d
* BUG-104321: Python Mpack Advisor should return MpackInstance block during
Host Component Layout Recommendation
* AMBARI-24025 Display Mpack Info on Service Summary Page
* AMBARI-24025 Display Mpack Info on Service Summary Page
* AMBARI-23986. Host components API call doesn't return all host components
(#1450)
* AMBARI-24030. Fixes the following : 1. Reading the Node Manager Host
(nmHost) correctly. 2. Comments the incorrectly implemented fn :
isServiceDeployed().
* AMBARI-24025 Display Mpack Info on Service Summary Page
* [AMBARI-24039] Quicklinks for HBASE are not displayed.
* [AMBARI-24033] Use servicegroup api instead of service to show installed
services in the UI.
* AMBARI-14714. Fix some unit tests (#1464)
* AMBARI-24046. Fix the incorrect string from config_name to config-name in
mpack_advisor.py (#1480)
---
ambari-server/src/main/resources/stacks/mpack_advisor.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ambari-server/src/main/resources/stacks/mpack_advisor.py
b/ambari-server/src/main/resources/stacks/mpack_advisor.py
index f5c3530..ddb9058 100644
--- a/ambari-server/src/main/resources/stacks/mpack_advisor.py
+++ b/ambari-server/src/main/resources/stacks/mpack_advisor.py
@@ -1548,13 +1548,13 @@ class MpackAdvisorImpl(MpackAdvisor):
userValue =
convertToNumber(configurations[configName]["properties"][propertyName])
maxValue =
convertToNumber(recommendedDefaults[configName]["property_attributes"][propertyName]["maximum"])
if userValue > maxValue:
- validationItems.extend([{"config_name": propertyName, "item":
self.getWarnItem("Value is greater than the recommended maximum of {0}
".format(maxValue))}])
+ validationItems.extend([{"config-name": propertyName, "item":
self.getWarnItem("Value is greater than the recommended maximum of {0}
".format(maxValue))}])
if "minimum" in
recommendedDefaults[configName]["property_attributes"][propertyName] and \
propertyName in
recommendedDefaults[configName]["properties"]:
userValue =
convertToNumber(configurations[configName]["properties"][propertyName])
minValue =
convertToNumber(recommendedDefaults[configName]["property_attributes"][propertyName]["minimum"])
if userValue < minValue:
- validationItems.extend([{"config_name": propertyName, "item":
self.getWarnItem("Value is less than the recommended minimum of {0}
".format(minValue))}])
+ validationItems.extend([{"config-name": propertyName, "item":
self.getWarnItem("Value is less than the recommended minimum of {0}
".format(minValue))}])
validatedItems = self.toConfigurationValidationProblems(validationItems,
configName)
for validatedItem in validatedItems:
item = dict(itemHead.items() + validatedItem.items())
--
To stop receiving notification emails like this one, please contact
[email protected].
