swagle commented on a change in pull request #5: [AMBARI-24723] Support wild cards in AppId and InstanceId fields in AMS GET API. URL: https://github.com/apache/ambari-metrics/pull/5#discussion_r222191550
########## File path: ambari-metrics-timelineservice/src/main/java/org/apache/ambari/metrics/core/timeline/discovery/TimelineMetricMetadataManager.java ########## @@ -87,6 +86,8 @@ AtomicBoolean SYNC_HOSTED_APPS_METADATA = new AtomicBoolean(false); AtomicBoolean SYNC_HOSTED_INSTANCES_METADATA = new AtomicBoolean(false); + private Map<String,Set<String>> appInstanceMap = new ConcurrentHashMap<>(); Review comment: Instead of this data structure why don't we do a Phoenix lookup with wildcard pass down? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
