aBabiichuk commented on a change in pull request #5: [AMBARI-24551] [Log Search UI] get rid of redundant requests after undoing or redoing several history steps URL: https://github.com/apache/ambari-logsearch/pull/5#discussion_r223407546
########## File path: ambari-logsearch-web/src/app/services/history-manager.service.ts ########## @@ -292,19 +292,12 @@ export class HistoryManagerService { * @param {object} value */ private handleUndoOrRedo(value: object): void { - const filtersForm = this.logsContainerService.filtersForm; this.hasNoPendingUndoOrRedo = false; Review comment: Looks like `hasNoPendingUndoOrRedo` and `isUndoOrRedo` aren't needed any more, as well as `onFormValueChanges` which handles those values ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services