adoroszlai commented on a change in pull request #7: AMBARI-24692. Use jdk8 as default compiler version URL: https://github.com/apache/ambari-logsearch/pull/7#discussion_r224185191
########## File path: ambari-logsearch-logfeeder/src/main/scripts/logfeeder.sh ########## @@ -80,8 +80,12 @@ else LOGFEEDER_GC_LOGFILE="$LOG_PATH_WITHOUT_SLASH/$LOGFEEDER_GC_LOGFILE" fi -LOGFEEDER_GC_OPTS="-XX:+PrintGCDetails -XX:+PrintGCDateStamps -Xloggc:$LOGFEEDER_GC_LOGFILE" -#LOGFEEDER_GC_OPTS="-Xlog:gc*:file=$LOGFEEDER_GC_LOGFILE:time" #TODO: check java version, use this if not JDK8 is used +java_version=$($JVM -version 2>&1 | grep 'java version' | cut -d'"' -f2 | cut -d'.' -f2) Review comment: Grepping for `java version` may fail to match if run with OpenJDK. See apache/ambari@b6309a8160151387510875a6d27c340da58eb626#diff-f442ddfc811d70249788d702e79e6813R1275 for working regex (so far). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
