adoroszlai commented on a change in pull request #53: AMBARI-23456. Generate 
markdown docs from internal annotations.
URL: https://github.com/apache/ambari-logsearch/pull/53#discussion_r238452094
 
 

 ##########
 File path: Makefile
 ##########
 @@ -46,6 +46,9 @@ rpm:
 deb:
        $(MAVEN_BINARY) clean package -Dbuild-deb -DskipTests 
-Djdk.version=$(LOGSEARCH_JAVA_VERSION)
 
+prop-docs:
+       $(MAVEN_BINARY) -pl ambari-logsearch-docs clean package exec:java 
-DskipTests -Djdk.version=$(LOGSEARCH_JAVA_VERSION)
 
 Review comment:
   With this command, one needs to install logsearch into local maven repo 
first to avoid build failure:
   
   ```
   $ make prop-docs
   mvn -pl ambari-logsearch-docs clean package exec:java -DskipTests 
-Djdk.version="1.8"
   ...
   [ERROR] Failed to execute goal on project ambari-logsearch-docs: Could not 
resolve dependencies for project 
org.apache.ambari:ambari-logsearch-docs:jar:3.0.0.0-SNAPSHOT: The following 
artifacts could not be resolved: 
org.apache.ambari:ambari-logsearch-logfeeder:jar:3.0.0.0-SNAPSHOT, 
org.apache.ambari:ambari-logsearch-server:jar:3.0.0.0-SNAPSHOT: Could not find 
artifact org.apache.ambari:ambari-logsearch-logfeeder:jar:3.0.0.0-SNAPSHOT in 
apache-hadoop (http://repo.hortonworks.com/content/groups/public/) -> [Help 1]
   ```
   
   Possible fixes:
   
   1. make:
      * declare make dependency `prop-docs: install`
      * remove `clean package` from `prop-docs` target
   2. maven ([source](https://stackoverflow.com/a/11094503) for second step):
      * add `-am` flag to `mvn` command
      * move configuration of `exec-maven-plugin` to the parent pom's 
`pluginManagement` section, and bind the execution to a lifecycle phase, eg. 
`prepare-package`
      * remove `ambari-logsearch-docs` from the module list to reduce overlap 
between `prop-docs` and `package` targets
   
   (Either 1 or 2 could work, only one of them is needed.)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to