kasakrisz commented on a change in pull request #54: AMBARI-23456. Add mkdocs 
support & markdown skeletons
URL: https://github.com/apache/ambari-logsearch/pull/54#discussion_r239062724
 
 

 ##########
 File path: 
ambari-logsearch-config-json/src/main/java/org/apache/ambari/logsearch/config/json/model/inputconfig/impl/InputS3FileDescriptorImpl.java
 ##########
 @@ -34,7 +34,7 @@
   @ShipperConfigElementDescription(
     path = "/input/[]/s3_access_key",
     type = "string",
-    description = "The access key used for AWS credentials."
+    description = "The access key used for AWS credentials. (Not supported yet 
through shipper configurations)"
 
 Review comment:
   Is it possible to omit these not supported properties from the doc? I think 
these should only be included if the functionality is supported.
   lines: 37, 46, 55 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to