tobias-istvan opened a new pull request #55: [Ambari-23820] [Log Search UI] add 
different options of hostname display
   # What changes were proposed in this pull request?
   Two main changes are here:
   - adding the user settings feature
   - displaying the short or full host names depending of the related user 
   ### User settings
   We had user settings service before but it was settings of the log index 
filter which is connected to the application not the user. So that the first 
change was to clean this up: renaming the user-settings to server-settings and 
creating user settings (with reducers, actions, effects and with a helper 
   There are multiple files affected by this rename change.
   I added two user settings there:
   - host name display setting
   - time zone setting
   Since the time zone settings moved to the user settings I moved the settings 
window on application level as I did with the user settings. In order to add 
the time zone map to the user settings window I created a separate component 
for the time zone selecting to decrease the dependency.
   The two settings modal is available in deep link via query params.
   ### Display short or long host names depending on the user settings
   I created a(n observable) pipe for displaying the host name in templates 
easier. We have a trade off: the open log tab label is not changeable after it 
is rendered.
   ## How was this patch tested?
   It was tested manually and by unit tests:
   PhantomJS 2.1.1 (Mac OS X 0.0.0): Executed 295 of 295 SUCCESS (12.245 secs / 
12.091 secs)
   ✨  Done in 43.81s.
   I also had a pair code review with @sardell (Shane Ardell), thanks for this.
   Please review [Ambari Contributing Guide]
before opening a pull request.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

Reply via email to