aBabiichuk commented on a change in pull request #55: [Ambari-23820] [Log
Search UI] add different options of hostname display
URL: https://github.com/apache/ambari-logsearch/pull/55#discussion_r239452930
##########
File path: ambari-logsearch-web/src/assets/i18n/en.json
##########
@@ -377,6 +377,22 @@
"page": "Page",
"query": "Query",
"users": "Users"
+ },
+
+ "userSettings": {
Review comment:
Declaring these props in nested form (i.e., `"userSettings": {"modalTitle":
{"displayShortHostName": {"description": "..."}}} ` instead of
`"userSettings.modalTitle.displayShortHostName."description": "..."`) makes
application harder to debug
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
