This is an automated email from the ASF dual-hosted git repository.
wuzhiguo pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ambari.git
The following commit(s) were added to refs/heads/trunk by this push:
new 5af6e562c2 AMBARI-25280: Improper error handling when managing Ambari
users (#3465)
5af6e562c2 is described below
commit 5af6e562c26da91417e4d6d8407eb0cb72e2d9a4
Author: Zhiguo Wu <[email protected]>
AuthorDate: Wed Nov 9 16:44:22 2022 +0800
AMBARI-25280: Improper error handling when managing Ambari users (#3465)
---
.../main/java/org/apache/ambari/server/api/services/ResultStatus.java | 2 +-
.../java/org/apache/ambari/server/api/handlers/ReadHandlerTest.java | 2 +-
.../ambari/server/api/services/serializers/JsonSerializerTest.java | 3 +--
3 files changed, 3 insertions(+), 4 deletions(-)
diff --git
a/ambari-server/src/main/java/org/apache/ambari/server/api/services/ResultStatus.java
b/ambari-server/src/main/java/org/apache/ambari/server/api/services/ResultStatus.java
index d62e709b10..96f30618fc 100644
---
a/ambari-server/src/main/java/org/apache/ambari/server/api/services/ResultStatus.java
+++
b/ambari-server/src/main/java/org/apache/ambari/server/api/services/ResultStatus.java
@@ -131,7 +131,7 @@ public class ResultStatus {
*/
public ResultStatus(STATUS status, Exception e) {
m_status = status;
- m_msg = e.toString();
+ m_msg = e.getMessage();
}
/**
diff --git
a/ambari-server/src/test/java/org/apache/ambari/server/api/handlers/ReadHandlerTest.java
b/ambari-server/src/test/java/org/apache/ambari/server/api/handlers/ReadHandlerTest.java
index e709c3707a..a721ac6185 100644
---
a/ambari-server/src/test/java/org/apache/ambari/server/api/handlers/ReadHandlerTest.java
+++
b/ambari-server/src/test/java/org/apache/ambari/server/api/handlers/ReadHandlerTest.java
@@ -174,7 +174,7 @@ public class ReadHandlerTest {
ReadHandler handler = new ReadHandler();
Result result = handler.handleRequest(request);
assertEquals(ResultStatus.STATUS.SERVER_ERROR,
result.getStatus().getStatus());
- assertEquals(systemException.toString(), result.getStatus().getMessage());
+ assertEquals(systemException.getMessage(),
result.getStatus().getMessage());
verify(request, resource, query, predicate);
}
diff --git
a/ambari-server/src/test/java/org/apache/ambari/server/api/services/serializers/JsonSerializerTest.java
b/ambari-server/src/test/java/org/apache/ambari/server/api/services/serializers/JsonSerializerTest.java
index a792a337fd..5cf5c19159 100644
---
a/ambari-server/src/test/java/org/apache/ambari/server/api/services/serializers/JsonSerializerTest.java
+++
b/ambari-server/src/test/java/org/apache/ambari/server/api/services/serializers/JsonSerializerTest.java
@@ -235,8 +235,7 @@ public class JsonSerializerTest {
" \"error\" : {\n" +
" \"key\" : \"key2\",\n" +
" \"code\" : 403,\n" +
- " \"message\" :
\"org.apache.ambari.server.security.authorization.AuthorizationException:"+
- " The authenticated user is not authorized to
perform the requested operation\"\n" +
+ " \"message\" : \"The authenticated user is not authorized to
perform the requested operation\"\n" +
" }\n" +
" }\n" +
" ]\n" +
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
