baiyangtx commented on code in PR #2676:
URL: https://github.com/apache/incubator-amoro/pull/2676#discussion_r1554989890
##########
docs/admin-guides/managing-optimizers.md:
##########
@@ -89,6 +89,19 @@ containers:
flink-conf.kubernetes.service-account: flink
# Service account that is used within kubernetes cluster.
```
+An example for flink session mode:
+
+```yaml
+containers:
+ - name: flinkContainer
+ container-impl: com.netease.arctic.server.manager.FlinkOptimizerContainer
+ properties:
+ target: session
# Flink run in session cluster
+ job-uri: "local:///opt/flink/usrlib/optimizer-job.jar"
# Optimizer job main jar
+ ams-optimizing-uri: thrift://ams.amoro.service.local:1261
# AMS optimizing uri
+ export.FLINK_CONF_DIR: /opt/flink/conf/
# Flink config dir, flink-conf.yaml should e in this dir, contains the
rest connection parameters of the session cluster
Review Comment:
I suggest adding the parameters that must be set in session mode to the
example. For example, jobmanager.url or zk-related settings
##########
docs/admin-guides/managing-optimizers.md:
##########
@@ -89,6 +89,19 @@ containers:
flink-conf.kubernetes.service-account: flink
# Service account that is used within kubernetes cluster.
```
+An example for flink session mode:
+
+```yaml
+containers:
+ - name: flinkContainer
+ container-impl: com.netease.arctic.server.manager.FlinkOptimizerContainer
+ properties:
+ target: session
# Flink run in session cluster
+ job-uri: "local:///opt/flink/usrlib/optimizer-job.jar"
# Optimizer job main jar
+ ams-optimizing-uri: thrift://ams.amoro.service.local:1261
# AMS optimizing uri
+ export.FLINK_CONF_DIR: /opt/flink/conf/
# Flink config dir, flink-conf.yaml should e in this dir, contains the
rest connection parameters of the session cluster
Review Comment:
Should optimizer-job.jar be added to the Flink Path when a session is
started in session mode?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
