This is an automated email from the ASF dual-hosted git repository.
jinsongzhou pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-amoro.git
The following commit(s) were added to refs/heads/master by this push:
new 1b9f1c9f3 [Hotfix] Change file seperator in suppressions file to adapt
to the Windows system (#2716)
1b9f1c9f3 is described below
commit 1b9f1c9f33bdedf47b8d6499e0d55aa5da1bee1a
Author: ZhouJinsong <[email protected]>
AuthorDate: Mon Apr 8 15:37:07 2024 +0800
[Hotfix] Change file seperator in suppressions file to adapt to the Windows
system (#2716)
* Change file seperator in suppressions file to adapt to windows system
* trigger ci when the checkstyle configuration files change
* Push for ci
* fix github workflow configuration files
---
.github/workflows/core-hadoop2-ci.yml | 1 +
.github/workflows/core-hadoop3-ci.yml | 1 +
.github/workflows/trino-ci.yml | 1 +
tools/maven/suppressions.xml | 58 ++++++++++++++++++-----------------
4 files changed, 33 insertions(+), 28 deletions(-)
diff --git a/.github/workflows/core-hadoop2-ci.yml
b/.github/workflows/core-hadoop2-ci.yml
index 5c79b7c72..a7aa72df8 100644
--- a/.github/workflows/core-hadoop2-ci.yml
+++ b/.github/workflows/core-hadoop2-ci.yml
@@ -24,6 +24,7 @@ on:
- "mixed-format/hive/**"
- "mixed-format/spark/**"
- "pom.xml"
+ - "tools/maven/**"
jobs:
build:
diff --git a/.github/workflows/core-hadoop3-ci.yml
b/.github/workflows/core-hadoop3-ci.yml
index 10736a47e..0a5858f70 100644
--- a/.github/workflows/core-hadoop3-ci.yml
+++ b/.github/workflows/core-hadoop3-ci.yml
@@ -24,6 +24,7 @@ on:
- "mixed-format/hive/**"
- "mixed-format/spark/**"
- "pom.xml"
+ - "tools/maven/**"
jobs:
build:
diff --git a/.github/workflows/trino-ci.yml b/.github/workflows/trino-ci.yml
index 117e57ba5..a59e93779 100644
--- a/.github/workflows/trino-ci.yml
+++ b/.github/workflows/trino-ci.yml
@@ -23,6 +23,7 @@ on:
- "mixed-format/hive/**"
- "mixed-format/trino/**"
- "pom.xml"
+ - "tools/maven/**"
jobs:
build:
diff --git a/tools/maven/suppressions.xml b/tools/maven/suppressions.xml
index e2722bca2..5eb514294 100644
--- a/tools/maven/suppressions.xml
+++ b/tools/maven/suppressions.xml
@@ -23,91 +23,93 @@ under the License.
"http://www.puppycrawl.com/dtds/suppressions_1_1.dtd";>
<suppressions>
+ <!-- Using ([/\\]) as the file path separator instead of (/)
+ enables it to be compatible with both Linux and Windows systems. -->
<suppress
- files="com/netease/arctic/utils/StatisticsFileUtil\.java"
+
files="com[/\\]netease[/\\]arctic[/\\]utils[/\\]StatisticsFileUtil\.java"
checks="Regexp"/>
<suppress
- files="com/netease/arctic/log/LogDataJsonSerialization\.java"
+
files="com[/\\]netease[/\\]arctic[/\\]log[/\\]LogDataJsonSerialization\.java"
checks="Regexp"/>
<suppress
- files="com/netease/arctic/log/LogDataToJsonConverters\.java"
+
files="com[/\\]netease[/\\]arctic[/\\]log[/\\]LogDataToJsonConverters\.java"
checks="Regexp"/>
<suppress
- files="com/netease/arctic/log/LogDataJsonDeserialization\.java"
+
files="com[/\\]netease[/\\]arctic[/\\]log[/\\]LogDataJsonDeserialization\.java"
checks="Regexp"/>
<suppress
- files="com/netease/arctic/log/JsonToLogDataConverters\.java"
+
files="com[/\\]netease[/\\]arctic[/\\]log[/\\]JsonToLogDataConverters\.java"
checks="Regexp"/>
<suppress
- files="com/netease/arctic/utils/TablePropertyUtil\.java"
+
files="com[/\\]netease[/\\]arctic[/\\]utils[/\\]TablePropertyUtil\.java"
checks="Regexp"/>
<suppress
- files="com/netease/arctic/api/config/OptimizingConfig\.java"
+
files="com[/\\]netease[/\\]arctic[/\\]api[/\\]config[/\\]OptimizingConfig\.java"
checks="Regexp"/>
<suppress
- files="com/netease/arctic/api/config/DataExpirationConfig\.java"
+
files="com[/\\]netease[/\\]arctic[/\\]api[/\\]config[/\\]DataExpirationConfig\.java"
checks="Regexp"/>
<suppress
- files="com/netease/arctic/api/config/TagConfiguration\.java"
+
files="com[/\\]netease[/\\]arctic[/\\]api[/\\]config[/\\]TagConfiguration\.java"
checks="Regexp"/>
<suppress
- files="com/netease/arctic/api/config/TableConfiguration\.java"
+
files="com[/\\]netease[/\\]arctic[/\\]api[/\\]config[/\\]TableConfiguration\.java"
checks="Regexp"/>
<suppress
- files="com/netease/arctic/server/RestCatalogService\.java"
+
files="com[/\\]netease[/\\]arctic[/\\]server[/\\]RestCatalogService\.java"
checks="Regexp"/>
<suppress
-
files="com/netease/arctic/server/persistence/converter/JsonObjectConverter\.java"
+
files="com[/\\]netease[/\\]arctic[/\\]server[/\\]persistence[/\\]converter[/\\]JsonObjectConverter\.java"
checks="Regexp"/>
<suppress
- files="com/netease/arctic/server/optimizing/OptimizingConfig\.java"
+
files="com[/\\]netease[/\\]arctic[/\\]server[/\\]optimizing[/\\]OptimizingConfig\.java"
checks="Regexp"/>
<suppress
-
files="com/netease/arctic/server/optimizing/plan/OptimizingEvaluator\.java"
+
files="com[/\\]netease[/\\]arctic[/\\]server[/\\]optimizing[/\\]plan[/\\]OptimizingEvaluator\.java"
checks="Regexp"/>
<suppress
- files="com/netease/arctic/server/optimizing/MetricsSummary\.java"
+
files="com[/\\]netease[/\\]arctic[/\\]server[/\\]optimizing[/\\]MetricsSummary\.java"
checks="Regexp"/>
<suppress
- files="com/netease/arctic/server/table/TagConfiguration\.java"
+
files="com[/\\]netease[/\\]arctic[/\\]server[/\\]table[/\\]TagConfiguration\.java"
checks="Regexp"/>
<suppress
- files="com/netease/arctic/server/table/TableConfiguration\.java"
+
files="com[/\\]netease[/\\]arctic[/\\]server[/\\]table[/\\]TableConfiguration\.java"
checks="Regexp"/>
<suppress
- files="com/netease/arctic/flink/interceptor/ProxyFactory\.java"
+
files="com[/\\]netease[/\\]arctic[/\\]flink[/\\]interceptor[/\\]ProxyFactory\.java"
checks="TodoComment"/>
<suppress
- files="org/apache/hadoop/util/VersionInfo\.java"
+ files="org[/\\]apache[/\\]hadoop[/\\]util[/\\]VersionInfo\.java"
checks="MethodName"/>
<suppress
-
files="com/netease/arctic/trino/iceberg/TestBaseArcticConnectorTest\.java"
+
files="com[/\\]netease[/\\]arctic[/\\]trino[/\\]iceberg[/\\]TestBaseArcticConnectorTest\.java"
checks="FileLength"/>
<suppress
- files="com/netease/arctic/trino/iceberg/BaseConnectorTest\.java"
+
files="com[/\\]netease[/\\]arctic[/\\]trino[/\\]iceberg[/\\]BaseConnectorTest\.java"
checks="FileLength"/>
<suppress
- files="com/netease/arctic/trino/keyed/KeyedConnectorSplit\.java"
+
files="com[/\\]netease[/\\]arctic[/\\]trino[/\\]keyed[/\\]KeyedConnectorSplit\.java"
checks="Regexp"/>
<suppress
- files="com/netease/arctic/trino/keyed/KeyedTableHandle\.java"
+
files="com[/\\]netease[/\\]arctic[/\\]trino[/\\]keyed[/\\]KeyedTableHandle\.java"
checks="Regexp"/>
<suppress
- files="com/netease/arctic/trino/delete/TrinoDeleteFile\.java"
+
files="com[/\\]netease[/\\]arctic[/\\]trino[/\\]delete[/\\]TrinoDeleteFile\.java"
checks="Regexp"/>
<suppress
- files="com/netease/arctic/trino/unkeyed/IcebergSplit\.java"
+
files="com[/\\]netease[/\\]arctic[/\\]trino[/\\]unkeyed[/\\]IcebergSplit\.java"
checks="Regexp"/>
<suppress
-
files="com/netease/arctic/trino/unkeyed/AdaptHiveIcebergTableHandle\.java"
+
files="com[/\\]netease[/\\]arctic[/\\]trino[/\\]unkeyed[/\\]AdaptHiveIcebergTableHandle\.java"
checks="Regexp"/>
<!-- BaseConnectorTest and TestBaseArcticConnectorTest can be replace by
shaded guava
because the shaded guava version is too low -->
<suppress
- files="com/netease/arctic/trino/iceberg/BaseConnectorTest.java"
+
files="com[/\\]netease[/\\]arctic[/\\]trino[/\\]iceberg[/\\]BaseConnectorTest.java"
checks="IllegalImport"/>
<suppress
-
files="com/netease/arctic/trino/iceberg/TestBaseArcticConnectorTest.java"
+
files="com[/\\]netease[/\\]arctic[/\\]trino[/\\]iceberg[/\\]TestBaseArcticConnectorTest.java"
checks="IllegalImport"/>
</suppressions>
