XBaith commented on code in PR #2711:
URL: https://github.com/apache/amoro/pull/2711#discussion_r1559070817
##########
core/src/main/java/com/netease/arctic/utils/TableFileUtil.java:
##########
@@ -80,6 +84,81 @@ public static void deleteEmptyDirectory(
}
}
+ /**
+ * Helper to delete files. Bulk deletion is used if possible.
+ *
+ * @param io arctic file io
+ * @param files files to delete
+ * @param concurrent controls concurrent deletion. Only applicable for
non-bulk FileIO
+ * @return deleted file count
+ */
+ public static int deleteFiles(
+ ArcticFileIO io, Set<String> files, boolean concurrent, ExecutorService
svc) {
Review Comment:
This way the code will be cleaner, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
