zhongqishang commented on PR #2734:
URL: https://github.com/apache/amoro/pull/2734#issuecomment-2049349517
```
validateConfig(expandedConfigurationMap);
serviceConfig = Configurations.fromObjectMap(expandedConfigurationMap);
```
@paul8263 @zhoujinsong
Would it be better if we adjusted the order of these two lines?
- `SqlSessionFactoryProvider.getInstance().init(serviceConfig)` will can use
some default values, this will be reduce error.
- We can use `Configurations#getString()` to get value.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
