This is an automated email from the ASF dual-hosted git repository.

zhongqishang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/amoro.git


The following commit(s) were added to refs/heads/master by this push:
     new 20a04d6e8 [AMORO-2733] Added db_type configuration check. 
database.type is mand… (#2734)
20a04d6e8 is described below

commit 20a04d6e8c42e9e7c606506b4d3ecabce6c0459a
Author: Paul Zhang <[email protected]>
AuthorDate: Fri Apr 12 10:10:42 2024 +0800

    [AMORO-2733] Added db_type configuration check. database.type is mand… 
(#2734)
    
    [AMORO-2733] Added db_type configuration check. database.type is mandatory
---
 .../java/com/netease/arctic/server/ArcticServiceContainer.java   | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git 
a/ams/server/src/main/java/com/netease/arctic/server/ArcticServiceContainer.java
 
b/ams/server/src/main/java/com/netease/arctic/server/ArcticServiceContainer.java
index 05e40b764..1ac3e1592 100644
--- 
a/ams/server/src/main/java/com/netease/arctic/server/ArcticServiceContainer.java
+++ 
b/ams/server/src/main/java/com/netease/arctic/server/ArcticServiceContainer.java
@@ -425,9 +425,14 @@ public class ArcticServiceContainer {
               (String) 
systemConfig.get(ArcticManagementConf.SERVER_EXPOSE_HOST.key()));
       systemConfig.put(ArcticManagementConf.SERVER_EXPOSE_HOST.key(), 
inetAddress.getHostAddress());
 
+      if (!systemConfig.containsKey(ArcticManagementConf.DB_TYPE.key())) {
+        throw new IllegalArgumentException(
+            "configuration " + ArcticManagementConf.DB_TYPE.key() + " must be 
set");
+      }
+
       // mysql config
-      if (((String) systemConfig.get(ArcticManagementConf.DB_TYPE.key()))
-          .equalsIgnoreCase(ArcticManagementConf.DB_TYPE_MYSQL)) {
+      if (ArcticManagementConf.DB_TYPE_MYSQL.equalsIgnoreCase(
+          (String) systemConfig.get(ArcticManagementConf.DB_TYPE.key()))) {
         if (!systemConfig.containsKey(ArcticManagementConf.DB_PASSWORD.key())
             || 
!systemConfig.containsKey(ArcticManagementConf.DB_USER_NAME.key())) {
           throw new IllegalArgumentException(

Reply via email to