baiyangtx commented on code in PR #2758:
URL: https://github.com/apache/amoro/pull/2758#discussion_r1571957981
##########
mixed-format/spark/v3.3/spark/src/main/java/org/apache/amoro/spark/table/ArcticSparkTable.java:
##########
@@ -128,20 +128,19 @@ public Transform[] partitioning() {
public Map<String, String> properties() {
ImmutableMap.Builder<String, String> propsBuilder = ImmutableMap.builder();
- String baseFileFormat =
- arcticTable
- .properties()
- .getOrDefault(
- TableProperties.BASE_FILE_FORMAT,
TableProperties.BASE_FILE_FORMAT_DEFAULT);
- String deltaFileFormat =
- arcticTable
- .properties()
- .getOrDefault(
- TableProperties.CHANGE_FILE_FORMAT,
TableProperties.CHANGE_FILE_FORMAT_DEFAULT);
- propsBuilder.put("base.write.format", baseFileFormat);
- propsBuilder.put("delta.write.format", deltaFileFormat);
- propsBuilder.put("provider", "arctic");
+ if
(!arcticTable.properties().containsKey(TableProperties.BASE_FILE_FORMAT)) {
+ propsBuilder.put("base.write.format",
TableProperties.BASE_FILE_FORMAT_DEFAULT);
Review Comment:
```suggestion
propsBuilder.put(TableProperties.BASE_FILE_FORMAT,
TableProperties.BASE_FILE_FORMAT_DEFAULT);
```
##########
mixed-format/spark/v3.2/spark/src/main/java/org/apache/amoro/spark/table/ArcticSparkTable.java:
##########
@@ -128,20 +128,19 @@ public Transform[] partitioning() {
public Map<String, String> properties() {
ImmutableMap.Builder<String, String> propsBuilder = ImmutableMap.builder();
- String baseFileFormat =
- arcticTable
- .properties()
- .getOrDefault(
- TableProperties.BASE_FILE_FORMAT,
TableProperties.BASE_FILE_FORMAT_DEFAULT);
- String deltaFileFormat =
- arcticTable
- .properties()
- .getOrDefault(
- TableProperties.CHANGE_FILE_FORMAT,
TableProperties.CHANGE_FILE_FORMAT_DEFAULT);
- propsBuilder.put("base.write.format", baseFileFormat);
- propsBuilder.put("delta.write.format", deltaFileFormat);
- propsBuilder.put("provider", "arctic");
+ if
(!arcticTable.properties().containsKey(TableProperties.BASE_FILE_FORMAT)) {
+ propsBuilder.put("base.write.format",
TableProperties.BASE_FILE_FORMAT_DEFAULT);
Review Comment:
```suggestion
propsBuilder.put(TableProperties.BASE_FILE_FORMAT,
TableProperties.BASE_FILE_FORMAT_DEFAULT);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
