tcodehuber commented on code in PR #2785:
URL: https://github.com/apache/amoro/pull/2785#discussion_r1578932940
##########
amoro-ams/amoro-ams-api/src/test/java/org/apache/amoro/api/metrics/TestMetricDefine.java:
##########
@@ -52,32 +52,32 @@ void testEquals(MetricDefine target, boolean
expectedEquality) {
static Stream<Arguments> provideMetricNamesForEquality() {
return Stream.of(
- // 相同的 name, tags, type 应该返回 true
+ // The same "name," "tags," and "type" should return true.
Arguments.of(
new MetricDefine(
"test-define", Arrays.asList("tag1", "tag2"),
MetricType.Counter, "description"),
true),
- // 不同的 name 应该返回 false
+ // Different "name" should return false.
Arguments.of(
new MetricDefine(
"different-name", Arrays.asList("tag1", "tag2"),
MetricType.Counter, "description"),
false),
- // 集合顺序不相同 tags 应该返回 true
+ // The order of tags in the collection is different, should return true
Arguments.of(
new MetricDefine(
"test-define", Arrays.asList("tag2", "tag1"),
MetricType.Counter, "description"),
true),
- // 不同的 tags 集合内容不同应该返回 false
+ // Different tags collections should return false
Arguments.of(
new MetricDefine(
"test-define", Arrays.asList("tag3", "tag4"),
MetricType.Counter, "description"),
false),
- // 不同的 MetricType 应该返回 false
+ // Different MetricType should return false
Arguments.of(
new MetricDefine(
"test-define", Arrays.asList("tag1", "tag2"),
MetricType.Gauge, "description"),
false),
- // 即使 description 不同，因为它不参与 equals 和 hashCode，所以应该返回 true
+ // Even though the description is different, because it does not
participate in equals and hashCode, should return true
Review Comment:
Return true if they are different with description. That is because the
description isn't truly involved in the functions of equals and hashCode.
##########
amoro-ams/amoro-ams-api/src/test/java/org/apache/amoro/api/metrics/TestMetricDefine.java:
##########
@@ -52,32 +52,32 @@ void testEquals(MetricDefine target, boolean
expectedEquality) {
static Stream<Arguments> provideMetricNamesForEquality() {
return Stream.of(
- // 相同的 name, tags, type 应该返回 true
+ // The same "name," "tags," and "type" should return true.
Arguments.of(
new MetricDefine(
"test-define", Arrays.asList("tag1", "tag2"),
MetricType.Counter, "description"),
true),
- // 不同的 name 应该返回 false
+ // Different "name" should return false.
Arguments.of(
new MetricDefine(
"different-name", Arrays.asList("tag1", "tag2"),
MetricType.Counter, "description"),
false),
- // 集合顺序不相同 tags 应该返回 true
+ // The order of tags in the collection is different, should return true
Arguments.of(
new MetricDefine(
"test-define", Arrays.asList("tag2", "tag1"),
MetricType.Counter, "description"),
true),
- // 不同的 tags 集合内容不同应该返回 false
+ // Different tags collections should return false
Arguments.of(
new MetricDefine(
"test-define", Arrays.asList("tag3", "tag4"),
MetricType.Counter, "description"),
false),
- // 不同的 MetricType 应该返回 false
+ // Different MetricType should return false
Review Comment:
Return false with different MetricType
##########
amoro-ams/amoro-ams-api/src/test/java/org/apache/amoro/api/metrics/TestMetricDefine.java:
##########
@@ -52,32 +52,32 @@ void testEquals(MetricDefine target, boolean
expectedEquality) {
static Stream<Arguments> provideMetricNamesForEquality() {
return Stream.of(
- // 相同的 name, tags, type 应该返回 true
+ // The same "name," "tags," and "type" should return true.
Arguments.of(
new MetricDefine(
"test-define", Arrays.asList("tag1", "tag2"),
MetricType.Counter, "description"),
true),
- // 不同的 name 应该返回 false
+ // Different "name" should return false.
Arguments.of(
new MetricDefine(
"different-name", Arrays.asList("tag1", "tag2"),
MetricType.Counter, "description"),
false),
- // 集合顺序不相同 tags 应该返回 true
+ // The order of tags in the collection is different, should return true
Arguments.of(
new MetricDefine(
"test-define", Arrays.asList("tag2", "tag1"),
MetricType.Counter, "description"),
true),
- // 不同的 tags 集合内容不同应该返回 false
Review Comment:
Return false if tags contain different elements inside
##########
amoro-ams/amoro-ams-api/src/test/java/org/apache/amoro/api/metrics/TestMetricDefine.java:
##########
@@ -52,32 +52,32 @@ void testEquals(MetricDefine target, boolean
expectedEquality) {
static Stream<Arguments> provideMetricNamesForEquality() {
return Stream.of(
- // 相同的 name, tags, type 应该返回 true
+ // The same "name," "tags," and "type" should return true.
Review Comment:
Return true with the same name, tags and type
##########
amoro-ams/amoro-ams-api/src/test/java/org/apache/amoro/api/metrics/TestMetricDefine.java:
##########
@@ -52,32 +52,32 @@ void testEquals(MetricDefine target, boolean
expectedEquality) {
static Stream<Arguments> provideMetricNamesForEquality() {
return Stream.of(
- // 相同的 name, tags, type 应该返回 true
+ // The same "name," "tags," and "type" should return true.
Arguments.of(
new MetricDefine(
"test-define", Arrays.asList("tag1", "tag2"),
MetricType.Counter, "description"),
true),
- // 不同的 name 应该返回 false
+ // Different "name" should return false.
Arguments.of(
new MetricDefine(
"different-name", Arrays.asList("tag1", "tag2"),
MetricType.Counter, "description"),
false),
- // 集合顺序不相同 tags 应该返回 true
+ // The order of tags in the collection is different, should return true
Review Comment:
Return true if tags are only different with the order
##########
docs/engines/flink/flink-dml.md:
##########
@@ -91,7 +91,7 @@ The following Hint Options are supported:
| scan.startup.timestamp-millis | (none) | Long | No
| Valid when
'scan.startup.mode' = 'timestamp', reads data from the specified Kafka time
with a millisecond timestamp starting at 00:00:00.000 GMT on 1 Jan 1970
|
| scan.startup.specific-offsets | (none) | String | No
| specify offsets for each
partition in case of 'specific-offsets' startup mode, e.g.
'partition:0,offset:42;partition:1,offset:300'.
|
| properties.group.id | (none) | String | If the
LogStore for an Amoro table is Kafka, it is mandatory to provide its details
while querying the table. Otherwise, it can be left empty. | The group id used
to read the Kafka Topic
|
-| properties.pulsar.admin.adminUrl | (none) | String | Required if
LogStore is pulsar, otherwise not required
| Pulsar admin 的 HTTP
URL，如：http://my-broker.example.com:8080
|
+| properties.pulsar.admin.adminUrl | (none) | String | Required if
LogStore is pulsar, otherwise not required
| Pulsar admin's HTTP
URL，for example:http://my-broker.example.com:8080
|
Review Comment:
Pulsar admin's HTTP URL, e.g., http://my-broker.example.com:8080
##########
amoro-ams/amoro-ams-api/src/test/java/org/apache/amoro/api/metrics/TestMetricDefine.java:
##########
@@ -52,32 +52,32 @@ void testEquals(MetricDefine target, boolean
expectedEquality) {
static Stream<Arguments> provideMetricNamesForEquality() {
return Stream.of(
- // 相同的 name, tags, type 应该返回 true
+ // The same "name," "tags," and "type" should return true.
Arguments.of(
new MetricDefine(
"test-define", Arrays.asList("tag1", "tag2"),
MetricType.Counter, "description"),
true),
- // 不同的 name 应该返回 false
+ // Different "name" should return false.
Review Comment:
Return false with the different name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
