jiamin13579 commented on code in PR #2784:
URL: https://github.com/apache/amoro/pull/2784#discussion_r1578947198
##########
amoro-mixed-format/amoro-mixed-format-flink/amoro-mixed-format-flink-common/src/main/java/org/apache/amoro/flink/util/DateTimeUtils.java:
##########
@@ -958,8 +958,8 @@ private static int julianExtract(TimeUnitRange range, int
julian) {
int j = julian + 32044;
int g = j / 146097;
int dg = j % 146097;
- int c = (dg / '躬' + 1) * 3 / 4;
- int dc = dg - c * '躬';
+ int c = (dg / 1461 + 1) * 3 / 4;
Review Comment:
Thanks, I checked the flink code and it also has Chinese characters. But
when I print the '躬' char and convert it to int, it is indeed 36524.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
