tcodehuber commented on PR #2786:
URL: https://github.com/apache/amoro/pull/2786#issuecomment-2078815245

   @jiamin13579 Thanks for your contribution. IMO, I suggest you can add 
`public static long xbToByte(String size)/ 
org.apache.amoro.server.dashboard.utils.AmsUtil` instead of import another util 
class. 
   
   Furthermore, it's better to inform end users if he/she inputed illegal value.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to