lianneli opened a new pull request, #2799:
URL: https://github.com/apache/amoro/pull/2799

   ## Why are the changes needed?
   Fix #2795 
   Close #2795 
   
   ## Brief change log
   - Add variables existed in templates but on in Values.yaml. Those variables 
are: nameOverride, commonLabels and commonAnnotations. 
   - Change Values.yaml: add more descriptions, refs and modify the file with 
standard format which can seems pretty.
   
   ## How was this patch tested?
   
   - [ ] Add some test cases that check the changes thoroughly including 
negative and positive cases if possible
   
   - [x] Add screenshots for manual tests if appropriate
   
   - [x] Run test locally before making a pull request
   
   test with unittest(#2794)
   This change is not dependency by #2794 , Just use it as test.
   
![image](https://github.com/apache/amoro/assets/19421187/3ff26a71-0274-4680-9902-96c93ebc7f15)
   
   
   ## Documentation
   
   - Does this pull request introduce a new feature? no
   - If yes, how is the feature documented?  none


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to