This is an automated email from the ASF dual-hosted git repository.

jinsongzhou pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/amoro.git


The following commit(s) were added to refs/heads/master by this push:
     new e2652b1e8 [AMORO-2772] Auto generate terminal sessionID if not 
specified (#2809)
e2652b1e8 is described below

commit e2652b1e87d34fdd48990f2372edf21ce7597daf
Author: Paul Lin <[email protected]>
AuthorDate: Tue May 7 14:46:24 2024 +0800

    [AMORO-2772] Auto generate terminal sessionID if not specified (#2809)
    
    feat: auto generate terminal sessionID if not specified
    
    Co-authored-by: ZhouJinsong <[email protected]>
---
 .../apache/amoro/server/dashboard/controller/TerminalController.java  | 4 ++++
 1 file changed, 4 insertions(+)

diff --git 
a/amoro-ams/amoro-ams-server/src/main/java/org/apache/amoro/server/dashboard/controller/TerminalController.java
 
b/amoro-ams/amoro-ams-server/src/main/java/org/apache/amoro/server/dashboard/controller/TerminalController.java
index ec64cada0..7eb20814c 100644
--- 
a/amoro-ams/amoro-ams-server/src/main/java/org/apache/amoro/server/dashboard/controller/TerminalController.java
+++ 
b/amoro-ams/amoro-ams-server/src/main/java/org/apache/amoro/server/dashboard/controller/TerminalController.java
@@ -29,6 +29,7 @@ import org.apache.amoro.server.terminal.TerminalManager;
 import java.util.Arrays;
 import java.util.List;
 import java.util.Map;
+import java.util.UUID;
 import java.util.stream.Collectors;
 
 /** The controller that handles terminal requests. */
@@ -66,6 +67,9 @@ public class TerminalController {
     Map<String, String> bodyParams = ctx.bodyAsClass(Map.class);
     String sql = bodyParams.get("sql");
     String terminalId = ctx.cookie("JSESSIONID");
+    if (terminalId == null) {
+      terminalId = UUID.randomUUID().toString();
+    }
     String sessionId = terminalManager.executeScript(terminalId, catalog, sql);
 
     ctx.json(OkResponse.of(new SessionInfo(sessionId)));

Reply via email to