xieyi888 commented on code in PR #2812:
URL: https://github.com/apache/amoro/pull/2812#discussion_r1593289045
##########
amoro-mixed-format/amoro-mixed-format-flink/amoro-mixed-format-flink-common/src/main/java/org/apache/amoro/flink/read/source/AmoroScanContext.java:
##########
@@ -38,14 +38,14 @@
import java.util.Objects;
/** This is an arctic source scan context. */
Review Comment:
```suggestion
/** This is an amoro source scan context. */
```
##########
amoro-mixed-format/amoro-mixed-format-flink/amoro-mixed-format-flink-common/src/main/java/org/apache/amoro/flink/read/AmoroSource.java:
##########
@@ -42,29 +42,29 @@
import org.apache.flink.core.io.SimpleVersionedSerializer;
/**
- * Arctic Source based of FLIP-27.
+ * Amoro Source based of FLIP-27.
*
- * <p>If ArcticSource is used as a build table in lookup join, it will be
implemented by temporal
- * join. Two source should use processing time as watermark. ArcticSource will
generate watermark
- * after first splits planned by ArcticSourceEnumerator having been finished.
+ * <p>If AmoroSource is used as a build table in lookup join, it will be
implemented by temporal
+ * join. Two source should use processing time as watermark. AmoroSource will
generate watermark
+ * after first splits planned by AmoroSourceEnumerator having been finished.
*/
-public class ArcticSource<T>
- implements Source<T, ArcticSplit, ArcticSourceEnumState>,
ResultTypeQueryable<T> {
+public class AmoroSource<T>
+ implements Source<T, AmoroSplit, AmoroSourceEnumState>,
ResultTypeQueryable<T> {
private static final long serialVersionUID = 1L;
- private final ArcticScanContext scanContext;
+ private final AmoroScanContext scanContext;
private final ReaderFunction<T> readerFunction;
private final TypeInformation<T> typeInformation;
- private final ArcticTableLoader loader;
+ private final AmoroTableLoader loader;
private final String tableName;
/**
* generate arctic watermark. This is only for lookup join arctic table, and
arctic table is used
Review Comment:
```suggestion
* generate amoro watermark. This is only for lookup join amoro table, and
amoro table is used
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
