link3280 commented on code in PR #2790:
URL: https://github.com/apache/amoro/pull/2790#discussion_r1593737489
##########
amoro-ams/amoro-ams-server/src/main/java/org/apache/amoro/server/optimizing/TaskRuntime.java:
##########
@@ -105,6 +105,7 @@ public void complete(OptimizerThread thread,
OptimizingTaskResult result) {
token = null;
threadId = -1;
});
+ owner.releaseResourcesIfNecessary();
Review Comment:
I get the idea now. The cancellation is now lock-free. No task lock is
needed, thus no deadlock.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
