zhoujinsong commented on code in PR #2849:
URL: https://github.com/apache/amoro/pull/2849#discussion_r1609559254
##########
amoro-mixed-format/amoro-mixed-format-spark/amoro-mixed-format-spark-3-common/src/test/java/org/apache/amoro/spark/test/MixedTableTestBase.java:
##########
@@ -100,7 +100,7 @@ public void cleanUpSource() {
return;
}
if (TestIdentifier.SOURCE_TYPE_ARCTIC.equalsIgnoreCase(source.sourceType))
{
Review Comment:
The old `arctic` source is kept to be compatible with previous versions.
So are you suggesting changing the variable name to SOURCE_TYPE_MIXED and
keeping the variable value to arctic?
If yes, I prefer to keep the old variable name and remove it in the next
versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
