zhoujinsong commented on code in PR #2863:
URL: https://github.com/apache/amoro/pull/2863#discussion_r1615420855
##########
amoro-ams/amoro-ams-server/src/main/java/org/apache/amoro/server/terminal/kyuubi/KyuubiTerminalSessionFactory.java:
##########
@@ -124,8 +125,11 @@ public TerminalSession create(TableMetaStore metaStore,
Configurations configura
Properties properties = new Properties();
if (!metaStore.isKerberosAuthMethod()) {
- properties.put(JdbcConnectionParams.AUTH_USER,
metaStore.getHadoopUsername());
Review Comment:
How about checking if the value is null before putting it into properties
and configuration?
I think it will be simpler if we fix it this way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
