baiyangtx commented on code in PR #2814:
URL: https://github.com/apache/amoro/pull/2814#discussion_r1616517838
##########
amoro-mixed-format/amoro-mixed-format-flink/amoro-mixed-format-flink-common/src/main/java/org/apache/amoro/flink/catalog/FlinkUnifiedCatalog.java:
##########
@@ -221,8 +226,26 @@ public void createTable(ObjectPath tablePath,
CatalogBaseTable table, boolean ig
TableIdentifier tableIdentifier =
TableIdentifier.of(
unifiedCatalog.name(), tablePath.getDatabaseName(),
tablePath.getObjectName());
+ if (!configuration.contains(TABLE_FORMAT)) {
+ // if user doesn't specify the table format, we try to load the table
and get the table
+ // format.
+ try {
+ AmoroTable amoroTable =
+ unifiedCatalog.loadTable(tableIdentifier.getDatabase(),
tableIdentifier.getTableName());
+ format = amoroTable.format();
+ } catch (NoSuchTableException | NoSuchDatabaseException e) {
+ String msg =
+ String.format(
+ "Can't decide table format of table %s, Please specify
'table.format' "
+ + "in table properties",
+ tableIdentifier.toString());
+ throw new CatalogException(msg);
+ }
+ }
+ final TableFormat catalogFormat = format;
Review Comment:
```suggestion
Preconditions.checkNotNull(format, "Lack required property:
table-format");
if(ignoreIfExists) {
try {
AmoroTable amoroTable =
unifiedCatalog.loadTable(tableIdentifier.getDatabase(),
tableIdentifier.getTableName());
return;
} catch (NoSuchTableException) {
// do nothing
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
