huyuanfeng2018 commented on issue #3005: URL: https://github.com/apache/amoro/issues/3005#issuecomment-2212980114
> Hi, > > I am confused about the description of this issue. AFAIK, the configuration `ams.clean-orphan-files.enabled=true` in the AMS configuration file controls whether to enable orphan-file-clean process for all tables in the AMS. In fact, it controls whether to enable a thread pool to execute these tasks. > > The configuration `clean-orphan-file.enabled=false` in the table properties controls whether to enable orphan-file-clean process on the table. > > So the orphan-file-clean process will execute only when `ams.clean-orphan-files.enabled=true` and `clean-orphan-file.enabled=true`. This statement seems to make sense, but this behavior does not seem to match other actions, such as `clean-dangling-delete-files`, which is `clean-dangling-delete-files` whether in the AMS configuration or in the table configuration. If this is the case we need to modify the clean-dangling-delete behavior to make it consistent -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
