zhoujinsong commented on code in PR #3013:
URL: https://github.com/apache/amoro/pull/3013#discussion_r1671754684
##########
amoro-ams/amoro-ams-optimizer/amoro-optimizer-spark/src/main/java/org/apache/amoro/optimizer/spark/SparkOptimizerExecutor.java:
##########
@@ -68,7 +68,11 @@ protected OptimizingTaskResult executeTask(OptimizingTask
task) {
return result;
} catch (Throwable r) {
LOG.error(
- "Optimizer executor[{}] executed task[{}] failed, and cost {}",
threadName, task, r);
+ "Optimizer executor[{}] executed task[{}] failed, and cost {}",
+ threadName,
+ task.getTaskId(),
+ (System.currentTimeMillis() - startTime),
+ r);
Review Comment:
log4j2 supports this format and can correctly log the exception stack trace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
