codecov-commenter commented on PR #3036: URL: https://github.com/apache/amoro/pull/3036#issuecomment-2227879254
## [Codecov](https://app.codecov.io/gh/apache/amoro/pull/3036?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: Patch coverage is `65.57377%` with `21 lines` in your changes missing coverage. Please review. > Project coverage is 27.63%. Comparing base [(`f1fbfa1`)](https://app.codecov.io/gh/apache/amoro/commit/f1fbfa1e4de5b22b92eb9e0fbcce348dea0931ee?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`d1da799`)](https://app.codecov.io/gh/apache/amoro/commit/d1da7993dfb32fe2986f3c98ef2b341813d28148?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 2 commits behind head on master. | [Files](https://app.codecov.io/gh/apache/amoro/pull/3036?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...java/org/apache/amoro/client/ThriftClientPool.java](https://app.codecov.io/gh/apache/amoro/pull/3036?src=pr&el=tree&filepath=amoro-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Famoro%2Fclient%2FThriftClientPool.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YW1vcm8tY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvYW1vcm8vY2xpZW50L1RocmlmdENsaWVudFBvb2wuamF2YQ==) | 30.43% | [14 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/amoro/pull/3036?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/apache/amoro/client/OptimizingClientPools.java](https://app.codecov.io/gh/apache/amoro/pull/3036?src=pr&el=tree&filepath=amoro-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Famoro%2Fclient%2FOptimizingClientPools.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YW1vcm8tY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvYW1vcm8vY2xpZW50L09wdGltaXppbmdDbGllbnRQb29scy5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/amoro/pull/3036?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../main/java/org/apache/amoro/client/PoolConfig.java](https://app.codecov.io/gh/apache/amoro/pull/3036?src=pr&el=tree&filepath=amoro-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Famoro%2Fclient%2FPoolConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YW1vcm8tY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvYW1vcm8vY2xpZW50L1Bvb2xDb25maWcuamF2YQ==) | 93.75% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/amoro/pull/3036?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (f1fbfa1) and HEAD (d1da799). Click for more details. > > <details><summary>HEAD has 1 upload less than BASE</summary> > >| Flag | BASE (f1fbfa1) | HEAD (d1da799) | >|------|------|------| >|core|1|0| ></details> <details><summary>Additional details and impacted files</summary> ```diff @@ Coverage Diff @@ ## master #3036 +/- ## ============================================ - Coverage 32.80% 27.63% -5.18% + Complexity 3827 2494 -1333 ============================================ Files 557 360 -197 Lines 46194 37126 -9068 Branches 6116 5371 -745 ============================================ - Hits 15152 10258 -4894 + Misses 29845 25908 -3937 + Partials 1197 960 -237 ``` | [Flag](https://app.codecov.io/gh/apache/amoro/pull/3036/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [core](https://app.codecov.io/gh/apache/amoro/pull/3036/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [trino](https://app.codecov.io/gh/apache/amoro/pull/3036/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `27.63% <65.57%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. </details> [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/amoro/pull/3036?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
