pjfanning commented on code in PR #8:
URL: https://github.com/apache/amoro-shade/pull/8#discussion_r1690297260


##########
amoro-shade-thrift/src/main/resources/META-INF/NOTICE:
##########
@@ -1,8 +1,5 @@
 amoro-shade-thrift
-Copyright (C) 2006 - 2019, The Apache Software Foundation

Review Comment:
   I think the copyright is right already and that the change is wrong
   
   better still, we should just keep the notice from the actual thrift jar



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to