zhoujinsong commented on issue #7: URL: https://github.com/apache/amoro-shade/issues/7#issuecomment-2249343831
> What software in the amoro-shade-jackson-2 is developed in the ASF? I think the Notice is wrong to claim that ASF has any significant contribution to this jar. Thanks for the review, @pjfanning. We are currently using the (ApacheNoticeResourceTransformer)[https://maven.apache.org/plugins/maven-shade-plugin/examples/resource-transformers.html#ApacheNoticeResourceTransformer] to automatically generate the content of the NOTICE file in the shade jars. It will include some auto-generated content like: ``` Apache Amoro-shade (incubating) Copyright 2024 The Apache Software Foundation This product includes software developed at The Apache Software Foundation (http://www.apache.org/). ``` and content in the `resources/META-INF/NOTICE`, like: ``` amoro-shade-jackson-2 Copyright 2024 The Apache Software Foundation This project bundles the following dependencies under the Apache Software License 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt) - com.fasterxml.jackson.core:jackson-annotations:2.14.2 - com.fasterxml.jackson.core:jackson-core:2.14.2 - com.fasterxml.jackson.core:jackson-databind:2.14.2 - com.fasterxml.jackson.dataformat:jackson-dataformat-csv:2.14.2 - com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:2.14.2 - com.fasterxml.jackson.datatype:jackson-datatype-jdk8:2.14.2 - com.fasterxml.jackson.datatype:jackson-datatype-jsr310:2.14.2 - org.yaml:snakeyaml:1.33 ``` and NOTICE file content in the jackson jars, like: ``` # Jackson JSON processor Jackson is a high-performance, Free/Open Source JSON processing library. It was originally written by Tatu Saloranta ([email protected]), and has been in development since 2007. It is currently developed by a community of developers. ## Licensing Jackson 2.x core and extension components are licensed under Apache License 2.0 To find the details that apply to this artifact see the accompanying LICENSE file. ## Credits A list of contributors may be found from CREDITS(-2.x) file, which is included in some artifacts (usually source distributions); but is always available from the source code management (SCM) system project uses. Jackson is a high-performance, Free/Open Source JSON processing library. It was originally written by Tatu Saloranta ([email protected]), and has been in development since 2007. It is currently developed by a community of developers, as well as supported commercially by FasterXML.com. Jackson core and extension components may be licensed under different licenses. To find the details that apply to this artifact see the accompanying LICENSE file. For more information, including possible other licensing options, contact FasterXML.com (http://fasterxml.com). A list of contributors may be found from CREDITS file, which is included in some artifacts (usually source distributions); but is always available from the source code management (SCM) system project uses. ``` Are you suggesting we should only keep the third part contents? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
