tcodehuber commented on code in PR #3081:
URL: https://github.com/apache/amoro/pull/3081#discussion_r1708444155
##########
amoro-ams/amoro-ams-dashboard/src/language/en.ts:
##########
@@ -198,8 +198,9 @@ export default {
totalDeleteFiles: 'delete-files',
branches: 'branches',
tags: 'tags',
+ consumer: 'consumer',
Review Comment:
consumers: 'consumers',
##########
amoro-ams/amoro-ams-dashboard/src/language/en.ts:
##########
@@ -198,8 +198,9 @@ export default {
totalDeleteFiles: 'delete-files',
branches: 'branches',
tags: 'tags',
+ consumer: 'consumer',
nothingToShow: 'Nothing to show',
- filterBranchesOrTags: 'Filter branches/tags',
+ filterBranchesOrTags: 'Filter branches/tags/consumer',
Review Comment:
filterBranchesOrTagsOrConsumers: 'Filter branches/tags/consumers',
Related `filterBranchesOrTags` in the code should be replaced by
`filterBranchesOrTagsOrConsumers`
##########
amoro-ams/amoro-ams-dashboard/src/language/zh.ts:
##########
@@ -198,8 +198,9 @@ export default {
totalDeleteFiles: '删除文件数量',
branches: '分支',
tags: '标签',
+ consumer: '用户',
nothingToShow: '无内容可展示',
- filterBranchesOrTags: '过滤分支/标签',
+ filterBranchesOrTags: '过滤分支/标签/用户',
Review Comment:
filterBranchesOrTagsOrConsumers: '过滤分支/标签/用户',
Related filterBranchesOrTags in the code should be replaced by
filterBranchesOrTagsOrConsumers
##########
amoro-ams/amoro-ams-dashboard/src/views/tables/components/Selector.vue:
##########
@@ -33,8 +33,14 @@ const tagSearchKey = ref<string>('')
const tabActiveKey = ref<string>(branchTypeMap.BRANCH)
const branchList = ref<IBranchItem[]>([])
const tagList = ref<IBranchItem[]>([])
-const actualBranchList = computed(() => branchList.value.filter(item =>
!branchSearchKey.value || item.label.includes(branchSearchKey.value)))
-const actualTagList = computed(() => tagList.value.filter(item =>
!tagSearchKey.value || item.label.includes(tagSearchKey.value)))
+const consumerList = ref<IBranchItem[]>([])
+const actualBranchList = computed(() =>branchList.value.filter((item)
=>!branchSearchKey.value ||
+ item.label.includes(branchSearchKey.value)))
+const actualTagList = computed(() =>tagList.value.filter((item) =>
!tagSearchKey.value ||
+item.label.includes(tagSearchKey.value)))
+const actualConsumerList = computed(() =>consumerList.value.filter((item) =>
!tagSearchKey.value ||
Review Comment:
Can we define a consumerSearchKey instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
