zhoujinsong commented on code in PR #3108:
URL: https://github.com/apache/amoro/pull/3108#discussion_r1726975809
##########
amoro-core/src/main/java/org/apache/amoro/utils/MixedCatalogUtil.java:
##########
@@ -21,28 +21,12 @@
import org.apache.amoro.TableFormat;
import org.apache.amoro.api.CatalogMeta;
import org.apache.amoro.api.TableMeta;
-import org.apache.amoro.io.AuthenticatedFileIO;
Review Comment:
It seems we should rename this class to `CatalogUtil` now.
##########
amoro-ams/amoro-ams-api/src/main/java/org/apache/amoro/api/config/DataExpirationConfig.java:
##########
@@ -166,9 +166,7 @@ public DataExpirationConfig(MixedTable table) {
}
public static DataExpirationConfig parse(Map<String, String> properties) {
- boolean gcEnabled =
- CompatiblePropertyUtil.propertyAsBoolean(
- properties, org.apache.iceberg.TableProperties.GC_ENABLED, true);
+ boolean gcEnabled = CompatiblePropertyUtil.propertyAsBoolean(properties,
"gc.enabled", true);
Review Comment:
I am not sure why we should change this here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
