zhoujinsong commented on code in PR #3107: URL: https://github.com/apache/amoro/pull/3107#discussion_r1734119410
########## amoro-core/src/main/java/org/apache/amoro/process/OptimizingStage.java: ########## @@ -16,7 +16,7 @@ * limitations under the License. */ -package org.apache.amoro.api.process; +package org.apache.amoro.process; Review Comment: What is the reason for moving these 3 classes from module `amoro-ams-api` to module `amoro-core`? ########## amoro-ams/amoro-ams-server/src/main/java/org/apache/amoro/server/dashboard/MixedAndIcebergTableDescriptor.java: ########## @@ -92,10 +101,11 @@ public class MixedAndIcebergTableDescriptor extends PersistentBase private static final Logger LOG = LoggerFactory.getLogger(MixedAndIcebergTableDescriptor.class); - private final ExecutorService executorService; Review Comment: Maybe we should move this implementation to module `amoro-iceberg-format`? If yes, we can do it in the next PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
