(amoro) branch master updated: [AMORO-3152] Make git-commit-plugin fail on no git dir configurable (#3126)

[jinsongzhou]

This is an automated email from the ASF dual-hosted git repository.

jinsongzhou pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/amoro.git


The following commit(s) were added to refs/heads/master by this push:
     new d26fc0209 [AMORO-3152] Make git-commit-plugin fail on no git dir 
configurable (#3126)
d26fc0209 is described below

commit d26fc02096c2bf5f91237583382c649ea129a033
Author: Congxian Qiu <qcx978132...@gmail.com>
AuthorDate: Tue Sep 3 10:45:37 2024 +0800

    [AMORO-3152] Make git-commit-plugin fail on no git dir configurable (#3126)
    
    We add conf to fail silent when no git dir before, so that it would not 
block the
    release process, but it may not fail in normal mode also, in this commit
    we add a profile to enable the check, so that build will fail when no git 
dir found.
---
 amoro-ams/amoro-ams-server/pom.xml | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/amoro-ams/amoro-ams-server/pom.xml 
b/amoro-ams/amoro-ams-server/pom.xml
index a959d6d56..f6c86ee5e 100644
--- a/amoro-ams/amoro-ams-server/pom.xml
+++ b/amoro-ams/amoro-ams-server/pom.xml
@@ -34,6 +34,10 @@
     <name>Amoro Project AMS Server</name>
     <url>https://amoro.apache.org</url>
 
+    <properties>
+        
<git-commit-id-plugin.fail-on-no-git-dir>false</git-commit-id-plugin.fail-on-no-git-dir>
+    </properties>
+
     <dependencies>
         <dependency>
             <groupId>org.apache.amoro</groupId>
@@ -415,8 +419,8 @@
                     </execution>
                 </executions>
                 <configuration>
-                    <failOnNoGitDirectory>false</failOnNoGitDirectory>
-                    
<failOnUnableToExtractRepoInfo>false</failOnUnableToExtractRepoInfo>
+                    
<failOnNoGitDirectory>${git-commit-id-plugin.fail-on-no-git-dir}</failOnNoGitDirectory>
+                    
<failOnUnableToExtractRepoInfo>${git-commit-id-plugin.fail-on-no-git-dir}</failOnUnableToExtractRepoInfo>
                     <dotGitDirectory>${project.basedir}/.git</dotGitDirectory>
                     <generateGitPropertiesFile>true</generateGitPropertiesFile>
                     <generateGitPropertiesFilename>
@@ -491,5 +495,11 @@
                 </dependency>
             </dependencies>
         </profile>
+        <profile>
+            <id>fail-on-no-git-dir</id>
+            <properties>
+                
<git-commit-id-plugin.fail-on-no-git-dir>true</git-commit-id-plugin.fail-on-no-git-dir>
+            </properties>
+        </profile>
     </profiles>
 </project>