Aireed commented on issue #1865:
URL: https://github.com/apache/amoro/issues/1865#issuecomment-2333057046

   I believe the intended effect of this feature should be as follows:
   Priority of group configuration: Table-level configuration > Regex rule 
configuration > Catalog default configuration.
   
   If a rule is manually configured on the table, it should take precedence.
   **Rule persistence**
   1. Regex rule configurations should not be written to the underlying table's 
properties.
   2. the rule stored in catalog properties
   
   **Rule change**
   1. Changes to regex rules will result in group changes for all affected 
tables.
   2. After a regex rule is deleted, the catalog's default configuration should 
take effect.
   
   It can take effect through TableRuntimeRefresh.
   
   **Rule queries**:
   1. When displaying the Optimize group list, show the rules affecting the 
tables which is collected from catalog prooperties.
   
![image](https://github.com/user-attachments/assets/7390eb3b-aa04-451b-a9f4-c9bcc2471bc9)
   
   2.Also display these configuration rules in the catalog's properties.
   
![image](https://github.com/user-attachments/assets/f80e22ee-2851-41e0-82a7-545f85fe25a2)
   
   IMO,Based on the issue description, there was an initial intention to 
configure this rule at the group level. I agree with this, but from an 
implementation standpoint, this will involve extensive changes in every 
properties call.
   
   **If we configure the regex rules in the catalog's properties, the effect of 
this property can be consolidated in the BasicUnkeyedTable::properties call 
within the MixedCatalogUtil::mergeCatalogPropertiesToTable method, making it 
convenient to implement.**
   
![image](https://github.com/user-attachments/assets/fec2ae30-570b-4d2a-9109-63745cfe0c69)
   
   
   @XBaith  @majin1102 @zhoujinsong  @nicochen  WDYT.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to