baiyangtx commented on code in PR #3167:
URL: https://github.com/apache/amoro/pull/3167#discussion_r1766820839
##########
amoro-ams/src/main/java/org/apache/amoro/server/optimizing/maintainer/TableMaintainer.java:
##########
@@ -60,9 +60,9 @@ default void cleanDanglingDeleteFiles(TableRuntime
tableRuntime) {
static TableMaintainer ofTable(AmoroTable<?> amoroTable) {
TableFormat format = amoroTable.format();
- if (format == TableFormat.MIXED_HIVE || format ==
TableFormat.MIXED_ICEBERG) {
+ if (TableFormat.MIXED_HIVE.equals(format) ||
TableFormat.MIXED_ICEBERG.equals(format)) {
Review Comment:
fixed
##########
amoro-format-iceberg/src/main/java/org/apache/amoro/mixed/CatalogLoader.java:
##########
@@ -88,7 +88,7 @@ private static String catalogImpl(String metastoreType,
Map<String, String> cata
tableFormats.size() == 1, "Catalog support only one table format
now.");
TableFormat tableFormat = tableFormats.iterator().next();
Preconditions.checkArgument(
- TableFormat.MIXED_HIVE == tableFormat || TableFormat.MIXED_ICEBERG ==
tableFormat,
+ TableFormat.MIXED_HIVE.equals(tableFormat) ||
TableFormat.MIXED_ICEBERG.equals(tableFormat),
Review Comment:
fixed
##########
amoro-format-iceberg/src/test/java/org/apache/amoro/catalog/TableTestBase.java:
##########
@@ -44,14 +45,11 @@ public void setupTable() {
this.tableMetaStore =
MixedFormatCatalogUtil.buildMetaStore(getCatalogMeta());
getUnifiedCatalog().createDatabase(TableTestHelper.TEST_DB_NAME);
- switch (getTestFormat()) {
- case MIXED_HIVE:
- case MIXED_ICEBERG:
- createMixedFormatTable();
- break;
- case ICEBERG:
- createIcebergFormatTable();
- break;
+ TableFormat format = getTestFormat();
+ if (TableFormat.MIXED_HIVE.equals(format) ||
TableFormat.MIXED_ICEBERG.equals(format)) {
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
