majin1102 commented on code in PR #3238:
URL: https://github.com/apache/amoro/pull/3238#discussion_r1796598372
##########
amoro-ams/src/main/java/org/apache/amoro/server/optimizing/TaskRuntime.java:
##########
@@ -22,30 +22,24 @@
import org.apache.amoro.api.OptimizingTask;
import org.apache.amoro.api.OptimizingTaskId;
import org.apache.amoro.api.OptimizingTaskResult;
-import org.apache.amoro.optimizing.RewriteFilesInput;
-import org.apache.amoro.optimizing.RewriteFilesOutput;
import org.apache.amoro.server.AmoroServiceConstants;
-import org.apache.amoro.server.dashboard.utils.OptimizingUtil;
import org.apache.amoro.server.exception.IllegalTaskStateException;
import org.apache.amoro.server.exception.OptimizingClosedException;
import org.apache.amoro.server.exception.TaskRuntimeException;
-import org.apache.amoro.server.optimizing.plan.TaskDescriptor;
import org.apache.amoro.server.persistence.StatedPersistentBase;
-import org.apache.amoro.server.persistence.TaskFilesPersistence;
import org.apache.amoro.server.persistence.mapper.OptimizingMapper;
import org.apache.amoro.server.resource.OptimizerThread;
import org.apache.amoro.shade.guava32.com.google.common.base.MoreObjects;
import org.apache.amoro.shade.guava32.com.google.common.collect.ImmutableMap;
import org.apache.amoro.shade.guava32.com.google.common.collect.ImmutableSet;
-import org.apache.amoro.utils.SerializationUtil;
import java.util.Map;
import java.util.Set;
-public class TaskRuntime extends StatedPersistentBase {
- private long tableId;
- private String partition;
+public class TaskRuntime<T extends StagedTaskDescriptor<?, ?, ?>> extends
StatedPersistentBase {
+
private OptimizingTaskId taskId;
+ private T taskDescriptor;
Review Comment:
This shall be loaded from db.
final is not applicable.
I updated the code, PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
