zhoujinsong commented on code in PR #3304:
URL: https://github.com/apache/amoro/pull/3304#discussion_r1820045305
##########
amoro-ams/dist/pom.xml:
##########
@@ -30,6 +30,9 @@
<name>Amoro Project AMS Dist</name>
<url>https://amoro.apache.org</url>
+ <properties>
+
<assembly.descriptor.file>src/main/assemblies/bin.xml</assembly.descriptor.file>
Review Comment:
It seems this PR contains some changes of another PR.
##########
pom.xml:
##########
@@ -143,6 +143,8 @@
<rocksdb-dependency-scope>compile</rocksdb-dependency-scope>
<lucene-dependency-scope>compile</lucene-dependency-scope>
+
+ <paimon-dependency-scope>compile</paimon-dependency-scope>
Review Comment:
Would it be more appropriate to change the default dependency scope to
runtime like before?
##########
amoro-core/pom.xml:
##########
@@ -149,6 +149,7 @@
<dependency>
<groupId>org.rocksdb</groupId>
<artifactId>rocksdbjni</artifactId>
+ <scope>${rocksdb-dependency-scope}</scope>
Review Comment:
I'm not sure if we need to emphasize the scope here. Perhaps it can be
inherited directly from the parent?
##########
amoro-ams/amoro-ams-server/pom.xml:
##########
@@ -310,14 +310,14 @@
<dependency>
<groupId>org.apache.paimon</groupId>
<artifactId>paimon-s3</artifactId>
- <scope>runtime</scope>
+ <scope>${paimon-dependency-scope}</scope>
Review Comment:
I'm not sure if we need to emphasize the scope here. Perhaps it can be
inherited directly from the parent?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
