zhangwl9 commented on code in PR #3339:
URL: https://github.com/apache/amoro/pull/3339#discussion_r1851583256


##########
amoro-format-iceberg/src/main/java/org/apache/amoro/formats/mixed/MixedCatalog.java:
##########
@@ -76,9 +77,13 @@ public AmoroTable<?> loadTable(String database, String 
table) {
 
   @Override
   public List<String> listTables(String database) {
-    return catalog.listTables(database).stream()
-        .map(TableIdentifier::getTableName)
-        .collect(Collectors.toList());
+    try {
+      return catalog.listTables(database).stream()
+          .map(TableIdentifier::getTableName)
+          .collect(Collectors.toList());
+    } catch (NoSuchDatabaseException e) {
+      throw new NoSuchDatabaseException(e, database);

Review Comment:
   The 'listTables' called in 
BasicMixedCatalog、BasicMixedIcebergCatalog、InternalMixedIcebergCatalog , etc., 
will throw other exceptions  such ad IllegalStateException not 
NoSuchDatabaseException. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to