klion26 commented on PR #3343: URL: https://github.com/apache/amoro/pull/3343#issuecomment-2497731976
@zhangwl9 thanks for the contribution, the change here LGTM. As there was some ut want to cover the logic, so could you please help to check 1. if the logic here in the master is right or not(if the code logic in the master branch can give the right result, maybe it is because the parameter in `PageHelper.startPage(pageNumber, limit, true)` -- line 517 has a higher priority than the parameter in the mapper) 2. if the logic here in the master is wrong, could you please please add more ut to cover the logic -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
