XBaith commented on code in PR #3345:
URL: https://github.com/apache/amoro/pull/3345#discussion_r1872467813
##########
charts/amoro/templates/amoro-configmap.yaml:
##########
@@ -52,6 +52,7 @@ data:
bind-port: {{ .Values.server.optimizing.port }}
http-server:
+ rest-auth-type: {{ .Values.amoroConf.ams.restAuthType }}
Review Comment:
The reason I prefer moving them under `server.rest` is that we already have
the property `HTTP_SERVER_REST_AUTH_TYPE` configured as part of the HTTP REST
service. It might be better to align with the original design. What do you
think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
